From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christian Borntraeger <borntraeger@de.ibm.com>
Subject: Re: [PATCH 1/2] kvm-s390: Implement the directed yield (diag 9c)
 hypervisor call for KVM
Date: Thu, 26 Apr 2012 14:19:29 +0200
Message-ID: <4F993D51.3000706@de.ibm.com>
References: <4F96D34E.4010405@redhat.com> <1335360639-6004-1-git-send-email-borntraeger@de.ibm.com> <1335360639-6004-2-git-send-email-borntraeger@de.ibm.com> <22DEE55A-B849-4530-A522-ED5D034C8506@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: Avi Kivity <avi@redhat.com>, Marcelo Tossati <mtosatti@redhat.com>,
	Carsten Otte <cotte@de.ibm.com>,
	Jens Freimann <jfrei@linux.vnet.ibm.com>,
	Cornelia Huck <cornelia.huck@de.ibm.com>,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	Heinz Graalfs <graalfs@linux.vnet.ibm.com>,
	KVM <kvm@vger.kernel.org>, Konstantin Weitz <WEITZKON@de.ibm.com>
To: Alexander Graf <agraf@suse.de>
Return-path: <kvm-owner@vger.kernel.org>
Received: from e06smtp16.uk.ibm.com ([195.75.94.112]:59447 "EHLO
	e06smtp16.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753504Ab2DZMT7 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 26 Apr 2012 08:19:59 -0400
Received: from /spool/local
	by e06smtp16.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted
	for <kvm@vger.kernel.org> from <borntraeger@de.ibm.com>;
	Thu, 26 Apr 2012 13:19:57 +0100
Received: from d06av03.portsmouth.uk.ibm.com (d06av03.portsmouth.uk.ibm.com [9.149.37.213])
	by d06nrmr1507.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q3QCJuRV1900646
	for <kvm@vger.kernel.org>; Thu, 26 Apr 2012 13:19:56 +0100
Received: from d06av03.portsmouth.uk.ibm.com (localhost.localdomain [127.0.0.1])
	by d06av03.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q3QCJX4j005161
	for <kvm@vger.kernel.org>; Thu, 26 Apr 2012 06:19:33 -0600
In-Reply-To: <22DEE55A-B849-4530-A522-ED5D034C8506@suse.de>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

>> +	kvm_for_each_vcpu(i, tcpu, kvm)
>> +		if (tcpu->vcpu_id == tid) {
> 
> Wouldn't
> 
>   kvm_get_vcpu(kvm, tid)
> 
> be what you want here?

Would be better in terms of scalability, but we can do that
only if kvm->vcpus[i].vcpu_id = i
Is that always the case?

Christian