From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758832Ab2DZTyl (ORCPT ); Thu, 26 Apr 2012 15:54:41 -0400 Received: from usmamail.tilera.com ([206.83.70.75]:22047 "EHLO USMAMAIL.TILERA.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756788Ab2DZTyk (ORCPT ); Thu, 26 Apr 2012 15:54:40 -0400 Message-ID: <4F99A7FF.9050908@tilera.com> Date: Thu, 26 Apr 2012 15:54:39 -0400 From: Chris Metcalf User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 MIME-Version: 1.0 To: Andrew Morton CC: Pawel Moll , Ingo Molnar , Peter Zijlstra , Rusty Russell , Stanislaw Gruszka , Subject: Re: [PATCH] init: fix bug where environment vars can't be passed via boot args References: <201204061711.q36HBpAh015060@lab-41.internal.tilera.com> <20120419151746.8c765ea7.akpm@linux-foundation.org> In-Reply-To: <20120419151746.8c765ea7.akpm@linux-foundation.org> X-Enigmail-Version: 1.4 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/19/2012 6:17 PM, Andrew Morton wrote: > On Fri, 6 Apr 2012 12:53:50 -0400 > Chris Metcalf wrote: > >> Commit 026cee0086f had the side-effect of dropping the '=' from >> the unknown boot arguments that are passed to init as environment >> variables. This is because parse_args() puts a NUL in the string >> where the '=' was when it passes the "param" and "val" pointers >> to the parsing subfunctions. Previously, unknown_bootoption() was >> the last parse_args() subfunction to run, and it carefully put back >> the '=' character. Now ignore_unknown_bootoption() is the last >> one to run, and it wasn't doing the necessary repair, so the >> envp params ended up with the embedded NUL and were no longer >> seen as valid environment variables by init. > This patch has been stuck in your tree for a week or two. The copy > there is missing Woody's Tested-by and (I suspect) his Reported-by and > Pawel's Acked-by. > > And because that patch is already in linux-next, I can't (or rather > don't want to) merge it myself. > > It needs to be merged into 3.4. Please fix up the changelog data and > send it in? I pulled it out of my linux-next tree and into my stable tree (for -rc changes). I'll send Linus a pull request now. Thanks for noticing. -- Chris Metcalf, Tilera Corp. http://www.tilera.com