From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753023Ab2D2RjV (ORCPT ); Sun, 29 Apr 2012 13:39:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57937 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752238Ab2D2RjT (ORCPT ); Sun, 29 Apr 2012 13:39:19 -0400 Message-ID: <4F9D7CB8.4000903@redhat.com> Date: Sun, 29 Apr 2012 14:39:04 -0300 From: Mauro Carvalho Chehab User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 MIME-Version: 1.0 To: Joe Perches CC: Borislav Petkov , Linux Edac Mailing List , Linux Kernel Mailing List , Aristeu Rozanski , Doug Thompson Subject: Re: [PATCH EDACv16 1/2] edac: Change internal representation to work with layers References: <1335289087-11337-1-git-send-email-mchehab@redhat.com> <1335291342-14922-1-git-send-email-mchehab@redhat.com> <20120427133304.GE9626@aftab.osrc.amd.com> <1335535895.25521.7.camel@joe2Laptop> <4F9AC44A.5000509@redhat.com> <20120428085223.GB26065@aftab.osrc.amd.com> <4F9D4F6E.4070106@redhat.com> <4F9D5A2E.2030506@redhat.com> <4F9D6A39.6040209@redhat.com> <1335717794.12022.19.camel@joe2Laptop> In-Reply-To: <1335717794.12022.19.camel@joe2Laptop> X-Enigmail-Version: 1.4 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em 29-04-2012 13:43, Joe Perches escreveu: > On Sun, 2012-04-29 at 13:20 -0300, Mauro Carvalho Chehab wrote: >> The script below is even better. After that, only 113 occurrences of __func__ >> is now found at drivers/edac, and some of them are not related to debugf[1-9], >> so they shouldn't be cover on a patch like that. >> I'll do some manual cleanup on it. > > Hi Mauro. > > Another thing you could do would be to > separate the level from the multiple macros, > use a single macro, and convert the uses. > > #define debugf(level, fmt, ...) > and change the uses to > debugf([0-n], "some format", args...) > > I believe that's the more predominate > kernel style for debugging macros with > a tested level or mask. Agreed. > Perhaps also add !CONFIG_EDAC_DEBUG > format/args checking to the debug statements. Most/all debug-only stuff are already checking for CONFIG_EDAC_DEBUG. There are a few static debug-only data/functions that aren't testing for it, but the compiler should remove the dead code anyway, so this shouldn't cause any harm. > Lastly, indenting the messages 2 tabs isn't > really useful, one or two spaces is probably > enough. agreed. > > I did this a bit ago so it may not apply > after your changes: Believe or not, it applied without troubles ;) I've added at the end of my experimental series, at: git://git.infradead.org/users/mchehab/edac.git experimental be careful if you use this branch, as I'm rebasing it every time I need to change something on this series. I'm keeping a non-rebased version, with one branch per review, at: git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-edac.git The current review is at hw_events_v17. Patches were already pushed there. they should be there after the usual kernel.org master/mirror replication delay. Regards, Mauro