All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean-Christophe DUBOIS <jcd@tribudubois.net>
To: Artem Bityutskiy <dedekind1@gmail.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] [JFFS2] load_xattr_datum need to return a positive number in case of unrecoverable error
Date: Mon, 30 Apr 2012 22:54:13 +0200	[thread overview]
Message-ID: <4F9EFBF5.6080908@tribudubois.net> (raw)
In-Reply-To: <1335714286.1942.14.camel@koala>

On 29/04/2012 17:44, Artem Bityutskiy wrote:
> On Thu, 2012-04-26 at 23:09 +0200, Jean-Christophe DUBOIS wrote:
>> Is this convincing enough?
> Sure, thanks.
>
>> You might think that the attibute corruption I am showing here is very
>> artificial but I can assure you that it does happen in the wild when you
>> get a power cut on your equipment while the GC was moving an attribute
>> node for example.
> This issue is for sure worth fixing.
So, will you accept this patch?
> Just make sure xattr corruption is
> handled the same way as data node corruption is handled. I do not
> remember a lot of details anymore, but I wrote you the main idea in the
> previous e-mail.
I will look at the other patch to do the xattr integrity checking in the 
GC second phase scanning.

Regards

JC
>

  reply	other threads:[~2012-04-30 20:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-11 20:54 [PATCH] [JFFS2] load_xattr_datum need to return a positive number in case of unrecoverable error Jean-Christophe DUBOIS
2012-04-22 13:08 ` Artem Bityutskiy
2012-04-22 13:16 ` Artem Bityutskiy
2012-04-22 17:35   ` Jean-Christophe DUBOIS
2012-04-25 13:59     ` Artem Bityutskiy
2012-04-26 21:09       ` Jean-Christophe DUBOIS
2012-04-29 15:44         ` Artem Bityutskiy
2012-04-30 20:54           ` Jean-Christophe DUBOIS [this message]
2012-05-01 12:15             ` Artem Bityutskiy
2012-05-01 14:31               ` Jean-Christophe DUBOIS

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F9EFBF5.6080908@tribudubois.net \
    --to=jcd@tribudubois.net \
    --cc=dedekind1@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.