From: Darren Hart <dvhart@linux.intel.com>
To: frank.rowand@am.sony.com
Cc: "linux-rt-users@vger.kernel.org" <linux-rt-users@vger.kernel.org>,
"williams@redhat.com" <williams@redhat.com>,
"jkacur@redhat.com" <jkacur@redhat.com>
Subject: Re: [PATCH 3/4] rt-tests: cyclictest avoid unneeded warning
Date: Wed, 02 May 2012 13:38:30 -0700 [thread overview]
Message-ID: <4FA19B46.2070005@linux.intel.com> (raw)
In-Reply-To: <4FA09FAC.8030505@am.sony.com>
On 05/01/2012 07:45 PM, Frank Rowand wrote:
> Avoid annoying warning message when tracing is not requested and the debug
> file system is not available.
>
> The same test already protects against calling event_enable_all().
>
> Signed-off-by: Frank Rowand <frank.rowand@am.sony.com>
Cross-compile tested for ARM. Visually inspected, looks sane.
Reviewed-by: Darren Hart <dvhart@linux.intel.com>
> ---
> src/cyclictest/cyclictest.c | 5 3 + 2 - 0 !
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> Index: b/src/cyclictest/cyclictest.c
> ===================================================================
> --- a/src/cyclictest/cyclictest.c
> +++ b/src/cyclictest/cyclictest.c
> @@ -1605,8 +1605,9 @@ int main(int argc, char **argv)
> if (trace_fd >= 0)
> close(trace_fd);
>
> - /* turn off all events */
> - event_disable_all();
> + if (enable_events)
> + /* turn off all events */
> + event_disable_all();
>
> /* turn off the function tracer */
> fileprefix = procfileprefix;
>
--
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel
next prev parent reply other threads:[~2012-05-02 20:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-02 2:35 [PATCH 1/4] rt-tests: printf format compile warning Frank Rowand
2012-05-02 2:44 ` [PATCH 2/4] rt-tests: cyclictest segfault with '-a' Frank Rowand
2012-05-02 20:37 ` Darren Hart
2012-05-02 2:45 ` [PATCH 3/4] rt-tests: cyclictest avoid unneeded warning Frank Rowand
2012-05-02 20:38 ` Darren Hart [this message]
2012-05-02 2:45 ` [PATCH 4/4] rt-tests: cyclictest warn of interaction between '-a', '--smp', and '--numa' Frank Rowand
2012-05-02 20:41 ` Darren Hart
2012-05-02 20:36 ` [PATCH 1/4] rt-tests: printf format compile warning Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA19B46.2070005@linux.intel.com \
--to=dvhart@linux.intel.com \
--cc=frank.rowand@am.sony.com \
--cc=jkacur@redhat.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.