From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <htejun@gmail.com>
Cc: Mark Lord <kernel@teksavvy.com>,
IDE/ATA development list <linux-ide@vger.kernel.org>
Subject: Re: [PATCH] libata-eh don't waste time retrying media errors (v3)
Date: Thu, 03 May 2012 22:25:49 -0400 [thread overview]
Message-ID: <4FA33E2D.1040204@garzik.org> (raw)
In-Reply-To: <20120502194603.GB6411@google.com>
On 05/02/2012 03:46 PM, Tejun Heo wrote:
> On Wed, May 02, 2012 at 03:43:05PM -0400, Mark Lord wrote:
>>>> +static inline int ata_eh_worth_retry(struct ata_queued_cmd *qc)
>>>
>>> Return bool?&& maybe split the patch into two - the first separating
>>> out the logic into a function, the latter changing emedia handling?
>>
>> I think the two-liner from v2 is better.
>
> Heh, I don't know. It probably doesn't matter all that much either
> way. Let's let Jeff decide. ;)
Queued v3. If anyone is motivated to make additional changes, base them
on top of v3...
next prev parent reply other threads:[~2012-05-04 2:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-01 20:12 ata_eh_link_autopsy: Bug? Mark Lord
2012-05-01 20:27 ` Mark Lord
2012-05-01 21:58 ` Tejun Heo
2012-05-01 23:48 ` Mark Lord
2012-05-01 23:52 ` Mark Lord
2012-05-02 0:00 ` [PATCH] libata-eh don't waste time retrying media errors Mark Lord
2012-05-02 3:03 ` [PATCH] libata-eh don't waste time retrying media errors (v2) Mark Lord
2012-05-02 15:54 ` Tejun Heo
2012-05-02 19:10 ` Mark Lord
2012-05-02 19:22 ` [PATCH] libata-eh don't waste time retrying media errors (v3) Mark Lord
2012-05-02 19:33 ` Tejun Heo
2012-05-02 19:43 ` Mark Lord
2012-05-02 19:46 ` Tejun Heo
2012-05-04 2:25 ` Jeff Garzik [this message]
2012-05-04 3:04 ` Mark Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA33E2D.1040204@garzik.org \
--to=jeff@garzik.org \
--cc=htejun@gmail.com \
--cc=kernel@teksavvy.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.