RE: [PATCH 2/3] remove saving/restoring method in Xend.

From: Ian Pratt <Ian.Pratt@eu.citrix.com>
To: Yuji Shimada <shimada-yxb@necst.nec.co.jp>,
	Keir Fraser <Keir.Fraser@eu.citrix.com>,
	Kouya Shimura <kouya@jp.fujitsu.com>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Cc: Ian Pratt <Ian.Pratt@eu.citrix.com>,
	Ross Philipson <Ross.Philipson@citrix.com>
Subject: RE: [PATCH 2/3] remove saving/restoring method in Xend.
Date: Wed, 22 Apr 2009 11:38:13 +0100	[thread overview]
Message-ID: <4FA716B1526C7C4DB0375C6DADBC4EA34172EC1DA5@LONPMAILBOX01.citrite.net> (raw)
In-Reply-To: <20090422111600.32AA.27C06F64@necst.nec.co.jp>

> This patch removes Xend method which saves/restores PCI configuration
> space.
> And this patch modifies the timing of saving/restoring configuration
> space like below.
> 
>   When pciback is bound to devices.
>    - Pciback saves configuration space.
> 
>   When pciback is unbound to devices.
>    - Pciback restores configuration space.
> 
>   When guest OS boots or a device is hotadded.
>    - Pciback restores configuration space.
>    - Pciback changes state of backend device to
> Initialised/Reconfigured.
>    - Xend waits for the transition to Initialised/Reconfigured.
> 
>   When guest OS shutdowns or a device is hotremoved.
>    - Pciback restores configuration space.
>    - Xend resets devices.
>      * If D-state of the device is not D0, the state is changed to D0
>        before resetting the device.
>    - Xend deassigns devices.

Does it not make sense to have pciback do the reset too? I think I've seen draft patches from Ross Philipson to move the reset into pciback -- they may even be checked in to the xenbits.xen.org/xenclient tree.

Thanks,
Ian