On 05/08/2012 05:30 PM, Eric Bénard wrote: > Hi Marc, > > Le Tue, 08 May 2012 17:18:34 +0200, > Marc Kleine-Budde a écrit : > >> On 05/08/2012 05:12 PM, Eric Bénard wrote: >>> tested on an i.MX257 >> >> What about the transceiver? Does is make sense to switch it off, too? >> > this could make sense on platform which have a transceiver with an > enable input. I can add flexcan_transceiver_switch after/before > flexcan_chip_disable/enable but won't be able to test that feature. I looked at two ethernet drivers: ethernet/intel/ixgbe/ixgbe_main.c and ethernet/intel/ixgbe/ixgbe_main.c and AFAICS they basically do the same as in open/close. (btw: the flexcan driver switches the transceiver on/off on open/close.) I haven't implemented any network driver pm yet, but what is a driver supposed to do in suspend/resume? Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |