From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pz0-f46.google.com ([209.85.210.46]:44789 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760833Ab2EJRqZ (ORCPT ); Thu, 10 May 2012 13:46:25 -0400 Received: by dady13 with SMTP id y13so1984815dad.19 for ; Thu, 10 May 2012 10:46:24 -0700 (PDT) Message-ID: <4FABFEE9.9060501@gmail.com> Date: Fri, 11 May 2012 01:46:17 +0800 From: Jiang Liu MIME-Version: 1.0 To: "Michael S. Tsirkin" CC: Amos Kong , linux-pci@vger.kernel.org, seabios@seabios.org, qemu-devel@nongnu.org, jbarnes@virtuousgeek.org, rjw@sisk.pl, alex.williamson@redhat.com, kevin@koconnor.net Subject: Re: [RESEND PATCH v3] hotplug: add device per func in ACPI DSDT tables References: <20111214010645.GA2044@morn.localdomain> <20120509072452.14872.92530.stgit@t> <4FABF832.1060708@gmail.com> <20120510174257.GD14647@redhat.com> In-Reply-To: <20120510174257.GD14647@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-pci-owner@vger.kernel.org List-ID: On 05/11/2012 01:42 AM, Michael S. Tsirkin wrote: > On Fri, May 11, 2012 at 01:17:38AM +0800, Jiang Liu wrote: >> On 05/09/2012 03:24 PM, Amos Kong wrote: >> >>> --- >>> src/ssdt-pcihp.dsl | 17 >>> src/ssdt-pcihp.hex | 8869 +++++++++++++++++++++++++++++++++++++++++++++++++++- >>> 2 files changed, 8781 insertions(+), 105 deletions(-) >>> >>> diff --git a/src/ssdt-pcihp.dsl b/src/ssdt-pcihp.dsl >>> index 4b435b8..2a3c326 100644 >>> --- a/src/ssdt-pcihp.dsl >>> +++ b/src/ssdt-pcihp.dsl >>> @@ -17,14 +17,23 @@ DefinitionBlock ("ssdt-pcihp.aml", "SSDT", 0x01, "BXPC", "BXSSDTPCIHP", 0x1) >>> // at runtime, if the slot is detected to not support hotplug. >>> // Extract the offset of the address dword and the >>> // _EJ0 name to allow this patching. >>> -#define hotplug_slot(slot) \ >>> - Device (S##slot) { \ >>> +#define hotplug_func(slot, fn) \ >>> + Device (S##slot##fn) { \ >>> ACPI_EXTRACT_NAME_DWORD_CONST aml_adr_dword \ >>> - Name (_ADR, 0x##slot##0000) \ >>> + Name (_ADR, 0x##slot##000##fn) \ >>> ACPI_EXTRACT_METHOD_STRING aml_ej0_name \ >>> Method (_EJ0, 1) { Return(PCEJ(0x##slot)) } \ >>> Name (_SUN, 0x##slot) \ >>> } >> It would be perfect if the Device object could also support _PS0 and _STA >> methods. > > It needs qemu support, and some backward compatibility hack. > Why? > >> Could we re-add the slot back after hot-removing it from the guest >> OS with this ACPI implementation? Say execute following scripts from guest OS. >> echo 0 > /sys/bus/pci/slot/xx/power >> echo 1 > /sys/bus/pci/slot/xx/power > > No because qemu removes device after eject. > Do you have a need for this functionality? What is it? I'm not familiar with qemu:( On native OS, admin could trigger PCI device hotplug operations through /sys/bus/pci/slot/xx/power. Not sure whether that's needed for guest OS too. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43575) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SSXRc-0001eF-W6 for qemu-devel@nongnu.org; Thu, 10 May 2012 13:46:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SSXRb-0002FC-6n for qemu-devel@nongnu.org; Thu, 10 May 2012 13:46:28 -0400 Received: from mail-pz0-f45.google.com ([209.85.210.45]:57682) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SSXRa-0002ES-Pu for qemu-devel@nongnu.org; Thu, 10 May 2012 13:46:27 -0400 Received: by dadv2 with SMTP id v2so2706104dad.4 for ; Thu, 10 May 2012 10:46:24 -0700 (PDT) Message-ID: <4FABFEE9.9060501@gmail.com> Date: Fri, 11 May 2012 01:46:17 +0800 From: Jiang Liu MIME-Version: 1.0 References: <20111214010645.GA2044@morn.localdomain> <20120509072452.14872.92530.stgit@t> <4FABF832.1060708@gmail.com> <20120510174257.GD14647@redhat.com> In-Reply-To: <20120510174257.GD14647@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RESEND PATCH v3] hotplug: add device per func in ACPI DSDT tables List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: linux-pci@vger.kernel.org, seabios@seabios.org, qemu-devel@nongnu.org, jbarnes@virtuousgeek.org, rjw@sisk.pl, alex.williamson@redhat.com, kevin@koconnor.net, Amos Kong On 05/11/2012 01:42 AM, Michael S. Tsirkin wrote: > On Fri, May 11, 2012 at 01:17:38AM +0800, Jiang Liu wrote: >> On 05/09/2012 03:24 PM, Amos Kong wrote: >> >>> --- >>> src/ssdt-pcihp.dsl | 17 >>> src/ssdt-pcihp.hex | 8869 +++++++++++++++++++++++++++++++++++++++++++++++++++- >>> 2 files changed, 8781 insertions(+), 105 deletions(-) >>> >>> diff --git a/src/ssdt-pcihp.dsl b/src/ssdt-pcihp.dsl >>> index 4b435b8..2a3c326 100644 >>> --- a/src/ssdt-pcihp.dsl >>> +++ b/src/ssdt-pcihp.dsl >>> @@ -17,14 +17,23 @@ DefinitionBlock ("ssdt-pcihp.aml", "SSDT", 0x01, "BXPC", "BXSSDTPCIHP", 0x1) >>> // at runtime, if the slot is detected to not support hotplug. >>> // Extract the offset of the address dword and the >>> // _EJ0 name to allow this patching. >>> -#define hotplug_slot(slot) \ >>> - Device (S##slot) { \ >>> +#define hotplug_func(slot, fn) \ >>> + Device (S##slot##fn) { \ >>> ACPI_EXTRACT_NAME_DWORD_CONST aml_adr_dword \ >>> - Name (_ADR, 0x##slot##0000) \ >>> + Name (_ADR, 0x##slot##000##fn) \ >>> ACPI_EXTRACT_METHOD_STRING aml_ej0_name \ >>> Method (_EJ0, 1) { Return(PCEJ(0x##slot)) } \ >>> Name (_SUN, 0x##slot) \ >>> } >> It would be perfect if the Device object could also support _PS0 and _STA >> methods. > > It needs qemu support, and some backward compatibility hack. > Why? > >> Could we re-add the slot back after hot-removing it from the guest >> OS with this ACPI implementation? Say execute following scripts from guest OS. >> echo 0 > /sys/bus/pci/slot/xx/power >> echo 1 > /sys/bus/pci/slot/xx/power > > No because qemu removes device after eject. > Do you have a need for this functionality? What is it? I'm not familiar with qemu:( On native OS, admin could trigger PCI device hotplug operations through /sys/bus/pci/slot/xx/power. Not sure whether that's needed for guest OS too.