From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45094) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SU1cU-0007Q2-S4 for qemu-devel@nongnu.org; Mon, 14 May 2012 16:11:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SU1cT-0003lM-1P for qemu-devel@nongnu.org; Mon, 14 May 2012 16:11:50 -0400 Received: from e8.ny.us.ibm.com ([32.97.182.138]:40067) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SU1cS-0003l7-Lm for qemu-devel@nongnu.org; Mon, 14 May 2012 16:11:48 -0400 Received: from /spool/local by e8.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 14 May 2012 16:11:45 -0400 Received: from d01relay07.pok.ibm.com (d01relay07.pok.ibm.com [9.56.227.147]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id A58AF6E804B for ; Mon, 14 May 2012 16:11:03 -0400 (EDT) Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by d01relay07.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q4EKB3SP24903710 for ; Mon, 14 May 2012 16:11:03 -0400 Received: from d01av03.pok.ibm.com (loopback [127.0.0.1]) by d01av03.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q4EKB2sg005708 for ; Mon, 14 May 2012 17:11:02 -0300 Message-ID: <4FB166D4.6050907@us.ibm.com> Date: Mon, 14 May 2012 15:11:00 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1335958273-769-1-git-send-email-pbonzini@redhat.com> <1335958273-769-8-git-send-email-pbonzini@redhat.com> In-Reply-To: <1335958273-769-8-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 07/21] qdev: fix -device foo,? List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, afaerber@suse.de, liwp@linux.vnet.ibm.com On 05/02/2012 06:30 AM, Paolo Bonzini wrote: > Since most property types do not have a parse property now, this was > broken. Fix it by looking at the setter instead. > > Signed-off-by: Paolo Bonzini Applied. Thanks. Regards, Anthony Liguori > --- > hw/qdev-monitor.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/qdev-monitor.c b/hw/qdev-monitor.c > index dc4e4e1..41b9e2c 100644 > --- a/hw/qdev-monitor.c > +++ b/hw/qdev-monitor.c > @@ -158,7 +158,7 @@ int qdev_device_help(QemuOpts *opts) > * for removal. This conditional should be removed along with > * it. > */ > - if (!prop->info->parse) { > + if (!prop->info->set) { > continue; /* no way to set it, don't show */ > } > error_printf("%s.%s=%s\n", driver, prop->name, > @@ -166,7 +166,7 @@ int qdev_device_help(QemuOpts *opts) > } > if (info->bus_info) { > for (prop = info->bus_info->props; prop&& prop->name; prop++) { > - if (!prop->info->parse) { > + if (!prop->info->set) { > continue; /* no way to set it, don't show */ > } > error_printf("%s.%s=%s\n", driver, prop->name,