From mboxrd@z Thu Jan 1 00:00:00 1970 From: Glauber Costa Subject: Re: [PATCH v5 2/2] decrement static keys on real destroy time Date: Wed, 16 May 2012 12:37:32 +0400 Message-ID: <4FB3674C.2030604@parallels.com> References: <1336767077-25351-1-git-send-email-glommer@parallels.com> <1336767077-25351-3-git-send-email-glommer@parallels.com> <4FB058D8.6060707@jp.fujitsu.com> <4FB3431C.3050402@parallels.com> <4FB3518B.3090205@parallels.com> <4FB3652D.2040909@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-2022-JP" Content-Transfer-Encoding: 7bit Cc: , , , , Tejun Heo , Li Zefan , Johannes Weiner , Michal Hocko , David Miller , Andrew Morton To: KAMEZAWA Hiroyuki Return-path: In-Reply-To: <4FB3652D.2040909-+CUm20s59erQFUHtdCDX3A@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org On 05/16/2012 12:28 PM, KAMEZAWA Hiroyuki wrote: > (2012/05/16 16:04), Glauber Costa wrote: > >> On 05/16/2012 10:03 AM, Glauber Costa wrote: >>>> BTW, what is the relationship between 1/2 and 2/2 ? >>> Can't do jump label patching inside an interrupt handler. They need to >>> happen when we free the structure, and I was about to add a worker >>> myself when I found out we already have one: just we don't always use it. >>> >>> Before we merge it, let me just make sure the issue with config Li >>> pointed out don't exist. I did test it, but since I've reposted this >>> many times with multiple tiny changes - the type that will usually get >>> us killed, I'd be more comfortable with an extra round of testing if >>> someone spotted a possibility. >>> >>> Who is merging this fix, btw ? >>> I find it to be entirely memcg related, even though it touches a file in >>> net (but a file with only memcg code in it) >>> >> >> For the record, I compiled test it many times, and the problem that Li >> wondered about seems not to exist. >> > > Ah...Hmm.....I guess dependency problem will be found in -mm if any rather than > netdev... > > David, can this bug-fix patch goes via -mm tree ? Or will you pick up ? > Another thing: Patch 2 in this series is of course dependent on patch 1 - which lives 100 % in memcg core. Without that, lockdep will scream while disabling the static key. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx117.postini.com [74.125.245.117]) by kanga.kvack.org (Postfix) with SMTP id 8CC1E6B004D for ; Wed, 16 May 2012 04:39:40 -0400 (EDT) Message-ID: <4FB3674C.2030604@parallels.com> Date: Wed, 16 May 2012 12:37:32 +0400 From: Glauber Costa MIME-Version: 1.0 Subject: Re: [PATCH v5 2/2] decrement static keys on real destroy time References: <1336767077-25351-1-git-send-email-glommer@parallels.com> <1336767077-25351-3-git-send-email-glommer@parallels.com> <4FB058D8.6060707@jp.fujitsu.com> <4FB3431C.3050402@parallels.com> <4FB3518B.3090205@parallels.com> <4FB3652D.2040909@jp.fujitsu.com> In-Reply-To: <4FB3652D.2040909@jp.fujitsu.com> Content-Type: text/plain; charset="ISO-2022-JP" Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: KAMEZAWA Hiroyuki Cc: cgroups@vger.kernel.org, linux-mm@kvack.org, devel@openvz.org, netdev@vger.kernel.org, Tejun Heo , Li Zefan , Johannes Weiner , Michal Hocko , David Miller , Andrew Morton On 05/16/2012 12:28 PM, KAMEZAWA Hiroyuki wrote: > (2012/05/16 16:04), Glauber Costa wrote: > >> On 05/16/2012 10:03 AM, Glauber Costa wrote: >>>> BTW, what is the relationship between 1/2 and 2/2 ? >>> Can't do jump label patching inside an interrupt handler. They need to >>> happen when we free the structure, and I was about to add a worker >>> myself when I found out we already have one: just we don't always use it. >>> >>> Before we merge it, let me just make sure the issue with config Li >>> pointed out don't exist. I did test it, but since I've reposted this >>> many times with multiple tiny changes - the type that will usually get >>> us killed, I'd be more comfortable with an extra round of testing if >>> someone spotted a possibility. >>> >>> Who is merging this fix, btw ? >>> I find it to be entirely memcg related, even though it touches a file in >>> net (but a file with only memcg code in it) >>> >> >> For the record, I compiled test it many times, and the problem that Li >> wondered about seems not to exist. >> > > Ah...Hmm.....I guess dependency problem will be found in -mm if any rather than > netdev... > > David, can this bug-fix patch goes via -mm tree ? Or will you pick up ? > Another thing: Patch 2 in this series is of course dependent on patch 1 - which lives 100 % in memcg core. Without that, lockdep will scream while disabling the static key. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: Glauber Costa Subject: Re: [PATCH v5 2/2] decrement static keys on real destroy time Date: Wed, 16 May 2012 12:37:32 +0400 Message-ID: <4FB3674C.2030604@parallels.com> References: <1336767077-25351-1-git-send-email-glommer@parallels.com> <1336767077-25351-3-git-send-email-glommer@parallels.com> <4FB058D8.6060707@jp.fujitsu.com> <4FB3431C.3050402@parallels.com> <4FB3518B.3090205@parallels.com> <4FB3652D.2040909@jp.fujitsu.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4FB3652D.2040909-+CUm20s59erQFUHtdCDX3A@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" To: KAMEZAWA Hiroyuki Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, devel-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Tejun Heo , Li Zefan , Johannes Weiner , Michal Hocko , David Miller , Andrew Morton On 05/16/2012 12:28 PM, KAMEZAWA Hiroyuki wrote: > (2012/05/16 16:04), Glauber Costa wrote: > >> On 05/16/2012 10:03 AM, Glauber Costa wrote: >>>> BTW, what is the relationship between 1/2 and 2/2 ? >>> Can't do jump label patching inside an interrupt handler. They need to >>> happen when we free the structure, and I was about to add a worker >>> myself when I found out we already have one: just we don't always use it. >>> >>> Before we merge it, let me just make sure the issue with config Li >>> pointed out don't exist. I did test it, but since I've reposted this >>> many times with multiple tiny changes - the type that will usually get >>> us killed, I'd be more comfortable with an extra round of testing if >>> someone spotted a possibility. >>> >>> Who is merging this fix, btw ? >>> I find it to be entirely memcg related, even though it touches a file in >>> net (but a file with only memcg code in it) >>> >> >> For the record, I compiled test it many times, and the problem that Li >> wondered about seems not to exist. >> > > Ah...Hmm.....I guess dependency problem will be found in -mm if any rather than > netdev... > > David, can this bug-fix patch goes via -mm tree ? Or will you pick up ? > Another thing: Patch 2 in this series is of course dependent on patch 1 - which lives 100 % in memcg core. Without that, lockdep will scream while disabling the static key.