All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Marek <mmarek@suse.cz>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: LKML <linux-kernel@vger.kernel.org>, linux-kbuild@vger.kernel.org
Subject: Re: [PATCH 1/3] scripts/patch-kernel: fix typos and compression comment
Date: Mon, 21 May 2012 13:35:00 +0200	[thread overview]
Message-ID: <4FBA2864.5010700@suse.cz> (raw)
In-Reply-To: <4FB9AD3C.3040909@xenotime.net>

On 21.5.2012 04:49, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@xenotime.net>
> 
> Fix typo, drop trailing whitespace, and add "xz" to list of
> compression types supported.
> 
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> ---
>  scripts/patch-kernel |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> --- lnx-34-rc7-pk.orig/scripts/patch-kernel
> +++ lnx-34-rc7-pk/scripts/patch-kernel
> @@ -26,8 +26,8 @@
>  #
>  #       Nick Holloway <Nick.Holloway@alfie.demon.co.uk>, 2nd January 1995.
>  #
> -# Added support for handling multiple types of compression. What includes
> -# gzip, bzip, bzip2, zip, compress, and plaintext. 
> +# Added support for handling multiple types of compression. That includes
> +# gzip, bzip, bzip2, zip, compress, xz, and plaintext.
>  #
>  #       Adam Sulmicki <adam@cfar.umd.edu>, 1st January 1997.

You are editing a changelog entry from time when xz did not exist. Why
don't you instead add a note to the usage examples at the beginning of
the script, that several compression formats are supported.

BTW, are you actually *using* this script? Wow, that would be two
confirmed users in this calendar year alone :).

Michal

  reply	other threads:[~2012-05-21 11:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-21  2:49 [PATCH 1/3] scripts/patch-kernel: fix typos and compression comment Randy Dunlap
2012-05-21 11:35 ` Michal Marek [this message]
2012-05-21 14:53   ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FBA2864.5010700@suse.cz \
    --to=mmarek@suse.cz \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.