All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC 2/2] hmp/qxl: info spice: add qxl0_mode & qxl0_guest_bug
Date: Mon, 21 May 2012 13:55:04 +0200	[thread overview]
Message-ID: <4FBA2D18.9040706@redhat.com> (raw)
In-Reply-To: <20120521113514.GF5846@garlic>

  Hi,

> OK, so I can fix this and remove the qxl0 hack at the same stroke. I was
> looking at using the system_bus, but that seems like another hack.

Didn't check what qom provides these days, searching for objects of a
certain type (for example a qxl device) should be possible IMO.  Dunno
whenever it actually is.

> The
> alternative is to keep a linked list of qxl devices private to qxl.c and
> use that, and the below functions become

Second best option if the QOM way doesn't fly.

> int qxl_guest_bug(int index)
> int qxl_mode(int index)
> int qxl_device_count(void)
> 
> How does that sound?

qxl_guest_bug(Object *dev) ?

cheers,
  Gerd

  reply	other threads:[~2012-05-21 11:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-21  9:04 [Qemu-devel] [RFC 1/2] hw/qxl: ignore guest from guestbug until reset Alon Levy
2012-05-21  9:04 ` [Qemu-devel] [RFC 2/2] hmp/qxl: info spice: add qxl0_mode & qxl0_guest_bug Alon Levy
2012-05-21  9:22   ` Gerd Hoffmann
2012-05-21 11:35     ` Alon Levy
2012-05-21 11:55       ` Gerd Hoffmann [this message]
2012-05-21  9:12 ` [Qemu-devel] [RFC 1/2] hw/qxl: ignore guest from guestbug until reset Gerd Hoffmann
2012-05-21 11:33   ` Alon Levy
2012-05-23 12:01 ` [Qemu-devel] [PATCH] " Alon Levy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FBA2D18.9040706@redhat.com \
    --to=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.