From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753205Ab2EVEiZ (ORCPT ); Tue, 22 May 2012 00:38:25 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:63261 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753046Ab2EVEiW (ORCPT ); Tue, 22 May 2012 00:38:22 -0400 Message-ID: <4FBB1839.6000606@gmail.com> Date: Mon, 21 May 2012 22:38:17 -0600 From: David Ahern User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: Jiri Olsa CC: acme@redhat.com, a.p.zijlstra@chello.nl, mingo@elte.hu, paulus@samba.org, cjashfor@linux.vnet.ibm.com, fweisbec@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/7] perf, tool: Fix endianity trick for adds_features bitmask References: <1337151548-2396-1-git-send-email-jolsa@redhat.com> <1337151548-2396-7-git-send-email-jolsa@redhat.com> In-Reply-To: <1337151548-2396-7-git-send-email-jolsa@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/16/12 12:59 AM, Jiri Olsa wrote: > Addons bitmask is stored as array of unsigned long values. The size > of the unsigned long is same as pointer size for architecture, so it > could differ for each architecture. > > To handle the endianity for adds_features bitmask, we first swap the > bitmaks as u64 values and check for HEADER_HOSTNAME bit. If not set we > want to unswap the u64 values and swap the adds_features as u32 values. > > This is currently buggy, since we swap just first 32bits of each u64 > value. Adding swap of the next 32 bits as well. Also adding& using > BITS_TO_U64 instead of BITS_TO_LONGS as counter max due to the different > size of unsigned longs per architecture. > > Note, running following to test perf endianity handling: > test 1) > - origin system: > # perf record -a -- sleep 10 (any perf record will do) > # perf report> report.origin > # perf archive perf.data > > - copy the perf.data, report.origin and perf.data.tar.bz2 > to a target system and run: > # tar xjvf perf.data.tar.bz2 -C ~/.debug > # perf report> report.target > # diff -u report.origin report.target > > - the diff should produce no output > (besides some white space stuff and possibly different > date/TZ output) > > test 2) > - origin system: > # perf record -ag -fo /tmp/perf.data -- sleep 1 > - mount origin system root to the target system on /mnt/origin > - target system: > # perf script --symfs /mnt/origin -I -i /mnt/origin/tmp/perf.data \ > --kallsyms /mnt/origin/proc/kallsyms > - complete perf.data header is displayed > > Signed-off-by: Jiri Olsa 32-bit ppc reading 64-bit x86 still does not work: # ======== # captured on: Sun May 20 19:23:23 2012 # ======== # Why not? It suggests there is still a bug in the processing of the adds_feature bitmap. David