From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752889Ab2E3Hku (ORCPT ); Wed, 30 May 2012 03:40:50 -0400 Received: from mtaout01-winn.ispmail.ntl.com ([81.103.221.47]:56921 "EHLO mtaout01-winn.ispmail.ntl.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751031Ab2E3Hks (ORCPT ); Wed, 30 May 2012 03:40:48 -0400 Message-ID: <4FC5CEF1.6000509@snewbury.org.uk> Date: Wed, 30 May 2012 08:40:33 +0100 From: Steven Newbury User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120410 Thunderbird/11.0.1 MIME-Version: 1.0 To: Bjorn Helgaas CC: Yinghai Lu , "H. Peter Anvin" , Linus Torvalds , Andrew Morton , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 02/11] PCI: Try to allocate mem64 above 4G at first References: <1337754877-19759-1-git-send-email-yinghai@kernel.org> <20120525043651.GA1391@google.com> <20120525193716.GA8817@google.com> <4FC50E09.4000204@zytor.com> In-Reply-To: X-Enigmail-Version: 1.4.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Cloudmark-Analysis: v=1.1 cv=JvdXmxIgLJv2/GthKqHpGJEEHukvLcvELVXUanXFreg= c=1 sm=0 a=pqf2rKvVzeEA:10 a=btQ-OHYhoqkA:10 a=8nJEP1OIZ-IA:10 a=xqWC_Br6kY4A:10 a=VwQbUJbxAAAA:8 a=1XWaLZrsAAAA:8 a=oGMlB6cnAAAA:8 a=xe8BsctaAAAA:8 a=muRISqVPowLOPLNURv0A:9 a=wPNLvfGTeEIA:10 a=LI9Vle30uBYA:10 a=UTB_XpHje0EA:10 a=CY6gl2JlH4YA:10 a=Nr6_PaRTXGiiY1EP:21 a=f586Hm5rvKGcg1aN:21 a=HpAAvcLHHh0Zw7uRqdWCyQ==:117 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 30/05/12 00:27, Bjorn Helgaas wrote: > On Tue, May 29, 2012 at 2:40 PM, Yinghai Lu > wrote: >> On Tue, May 29, 2012 at 12:23 PM, Bjorn Helgaas >> wrote: >>> On Tue, May 29, 2012 at 12:17 PM, Yinghai Lu >>> wrote: >>>> On Tue, May 29, 2012 at 10:57 AM, H. Peter Anvin >>>> wrote: >>>>> On 05/29/2012 10:55 AM, Yinghai Lu wrote: *SNIP* >> >> >> ok, please check the version, that put back PCI_MAX_RESOURCE_32 >> for io ports. >> >> also RFC to limit for 16 bit ioport handling. only help other >> arches that does support 32bit ioports but have bridges only >> support 16bit io ports. > > I don't understand this one at all. It looks like you mashed > together at least two changes: (1) prefer I/O space above 64K if > available, and (2) mark secondary bus resources with > IORESOURCE_IO_32 when the P2P bridge I/O window address decode type > is PCI_IO_RANGE_TYPE_32 and use that to limit allocations. > > I don't see the justification for (1). What problem does this > solve? > I can potentially see this helping with hotplug, where a new device has only 16 bit io ports, but if there's no space remaining under 64k allocation would fail. Preferring above 64k means preserving that limited resource. This is exactly equivalent to my original motivation for preferring 64 bit PCI mem in order to preserve 32 bit address space for hotplug devices without 64 bit BARs. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk/FzvEACgkQGcb56gMuC61lYwCfchbsyzN5KLCWTuyQiMcJR0DH l4gAoJAY1D0HN6m5JnQLu705hvm85p5a =whd3 -----END PGP SIGNATURE-----