From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?VsOhZ8OzIFRpYm9y?= Date: Sun, 03 Jun 2012 17:03:13 +0200 Subject: [U-Boot] [PATCH] fix IDE_BUS(dev) macro In-Reply-To: <20120417190649.GA22913@w500.iskon.local> References: <20120417190649.GA22913@w500.iskon.local> Message-ID: <4FCB7CB1.9080802@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi, I've tested this IDE patch on my NAS6220 and it works. U-boot detect both HDD correctly and boot from them. Cheers, Tibor -------- Original message -------- IDE_BUS assumes that each bus has two devices and thus returns the first bus even when the second one should be probed. Signed-off-by: Simon Baatz Tested-by: Luka Perkov --- Simon discovered this while adding support for new board IB NAS6210. More info can be found here: http://lists.denx.de/pipermail/u-boot/2012-April/122525.html When this is commited I will do a coding style cleanup. There are tabs after few "#define" parts in include/ide.h. include/ide.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/ide.h b/include/ide.h index 8ecc9dd..385e909 100644 --- a/include/ide.h +++ b/include/ide.h @@ -24,7 +24,7 @@ #ifndef _IDE_H #define _IDE_H -#define IDE_BUS(dev) (dev >> 1) +#define IDE_BUS(dev) (dev / (CONFIG_SYS_IDE_MAXDEVICE / CONFIG_SYS_IDE_MAXBUS)) #define ATA_CURR_BASE(dev) (CONFIG_SYS_ATA_BASE_ADDR+ide_bus_offset[IDE_BUS(dev)])