All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2] DRM: add drm gem cma helper
Date: Mon, 04 Jun 2012 11:08:20 +0200	[thread overview]
Message-ID: <4FCC7B04.3070103@metafoo.de> (raw)
In-Reply-To: <1338451734-20232-1-git-send-email-s.hauer@pengutronix.de>

On 05/31/2012 10:08 AM, Sascha Hauer wrote:
> [...]
> diff --git a/drivers/gpu/drm/drm_gem_cma_helper.c
b/drivers/gpu/drm/drm_gem_cma_helper.c
> new file mode 100644
> index 0000000..d8c0dc7
> --- /dev/null
> +++ b/drivers/gpu/drm/drm_gem_cma_helper.c
> @@ -0,0 +1,243 @@
> +/*
> + * drm gem cma (contiguous memory allocator) helper functions
> + *
> + * Copyright (C) 2012 Sascha Hauer, Pengutronix
> + *
> + * Based on Samsung Exynos code
> + *
> + * Copyright (c) 2011 Samsung Electronics Co., Ltd.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License
> + * as published by the Free Software Foundation; either version 2
> + * of the License, or (at your option) any later version.
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +#include <drm/drmP.h>
> +#include <drm/drm.h>
> +#include <drm/drm_gem_cma_helper.h>

Sorry, forgot to mention this during the v1 review. This needs
'#include <linux/export.h>' for EXPORT_SYMBOL_GPL. I get compile errors
otherwise. Maybe it also makes sense to include linux/slab.h,
linux/dma-mapping.h, linux/mm.h and linux/mutex.h since those are only
implicitly included right now.

- Lars

  parent reply	other threads:[~2012-06-04  9:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-31  8:08 [PATCH v2] DRM: add drm gem cma helper Sascha Hauer
2012-05-31  9:36 ` Laurent Pinchart
2012-05-31 15:29   ` InKi Dae
2012-06-05  7:56     ` Sascha Hauer
2012-06-05 13:54       ` InKi Dae
2012-06-06  8:20         ` Sascha Hauer
2012-06-05  7:49   ` Sascha Hauer
2012-06-05  8:05     ` Laurent Pinchart
2012-06-04  9:08 ` Lars-Peter Clausen [this message]
2012-06-27 11:38 ` Laurent Pinchart
2012-06-27 13:01   ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FCC7B04.3070103@metafoo.de \
    --to=lars@metafoo.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.