From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:34817)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1ScyOs-0006FO-M3
	for qemu-devel@nongnu.org; Fri, 08 Jun 2012 08:34:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1ScyOq-0004yy-RR
	for qemu-devel@nongnu.org; Fri, 08 Jun 2012 08:34:46 -0400
Received: from cantor2.suse.de ([195.135.220.15]:43033 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1ScyOq-0004yr-Kv
	for qemu-devel@nongnu.org; Fri, 08 Jun 2012 08:34:44 -0400
Message-ID: <4FD1F160.9050402@suse.de>
Date: Fri, 08 Jun 2012 14:34:40 +0200
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1337742502-28565-1-git-send-email-afaerber@suse.de>
	<1337742502-28565-5-git-send-email-afaerber@suse.de>
	<20120608082006.GA22512@thinkpad.mammed.net>
	<4FD1C1AF.2020208@suse.de>
	<20120608120508.GC22512@thinkpad.mammed.net>
In-Reply-To: <20120608120508.GC22512@thinkpad.mammed.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH qom-next 04/59] pc: Add CPU as
	/machine/cpu[n]
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Igor Mammedov <imammedo@redhat.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org, Igor Mammedov <niallain@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>

Am 08.06.2012 14:05, schrieb Igor Mammedov:
> On Fri, Jun 08, 2012 at 11:11:11AM +0200, Andreas F=E4rber wrote:
>> Another factor that is making this slightly difficult is that there ar=
e
>> three APIC subclasses. Currently they all have an instance_size of
>> sizeof(APICCommonState) so it could be created in-place if it actually
>> is a part (child<>) of the CPU wrt hot-plug. Creating objects with
>> object_new() in QOM instance_init is forbidden.
> Any particular reason why object_new() in intifn is not acceptable?

It allocates memory, which may fail. The initfn must not fail, the
realizefn may return an Error object.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg