From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34554) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sf7ek-0006qS-Vq for qemu-devel@nongnu.org; Thu, 14 Jun 2012 06:52:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sf7ej-0000fa-8p for qemu-devel@nongnu.org; Thu, 14 Jun 2012 06:52:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30919) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sf7ej-0000f9-0n for qemu-devel@nongnu.org; Thu, 14 Jun 2012 06:52:01 -0400 Message-ID: <4FD9C24A.70906@redhat.com> Date: Thu, 14 Jun 2012 12:51:54 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1339598189-17933-1-git-send-email-wdongxu@linux.vnet.ibm.com> <1339598189-17933-4-git-send-email-wdongxu@linux.vnet.ibm.com> In-Reply-To: <1339598189-17933-4-git-send-email-wdongxu@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/6] qemu-img: add-cow will not support convert List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dong Xu Wang Cc: qemu-devel@nongnu.org Am 13.06.2012 16:36, schrieb Dong Xu Wang: > add-cow file can't live alone, must together will image_file and backing_file. > If we implement qemu-img convert operation for add-cow file format, we must > create image_file and backing_file manually, that will be confused for users, > so we just ignore add-cow format while doing converting. > > Signed-off-by: Dong Xu Wang NACK. This stupid "let's drop the feature, it might confuse users" attitude is known from Gnome, but not from qemu. There's no technical reason to forbid it and anyone who manages to create a valid add-cow image will also be able to specify the very same options to a convert command. Also, having image format specific code in qemu-img is evil. Kevin