From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756941Ab2FON6M (ORCPT ); Fri, 15 Jun 2012 09:58:12 -0400 Received: from mail-ee0-f46.google.com ([74.125.83.46]:38148 "EHLO mail-ee0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754204Ab2FON6J (ORCPT ); Fri, 15 Jun 2012 09:58:09 -0400 Message-ID: <4FDB3F6C.9000509@linaro.org> Date: Fri, 15 Jun 2012 14:58:04 +0100 From: Lee Jones User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120410 Thunderbird/11.0.1 MIME-Version: 1.0 To: Srinidhi Kasagar CC: Linus WALLEIJ , "arnd@arndb.de" , "linux-kernel@vger.kernel.org" , "grant.likely@secretlab.ca" , "linux-arm-kernel@lists.infradead.org" , "linux-i2c@vger.kernel.org" Subject: Re: Fwd: [PATCH 1/3] i2c: Add Device Tree support to the Nomadik I2C driver References: <1339428307-3850-10-git-send-email-lee.jones@linaro.org> <4FD8BAD2.50703@linaro.org> <4FDAFA17.6050502@linaro.org> <20120615115042.GA27480@bnru02> <4FDB2E57.4030904@linaro.org> <20120615130544.GA28537@bnru02> <4FDB3642.5030804@linaro.org> <20120615133729.GA12716@bnru02> In-Reply-To: <20120615133729.GA12716@bnru02> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/06/12 14:37, Srinidhi Kasagar wrote: > On Fri, Jun 15, 2012 at 15:18:58 +0200, Lee Jones wrote: >> On 15/06/12 14:05, Srinidhi Kasagar wrote: >>> On Fri, Jun 15, 2012 at 14:45:11 +0200, Lee Jones wrote: >>>> On 15/06/12 12:50, Srinidhi Kasagar wrote: >>>>> [...] >>>>>> >>>>>> >>>>>> From: Lee Jones >>>>>> Date: Tue, 17 Apr 2012 16:04:13 +0100 >>>>>> Subject: [PATCH 1/1] i2c: Add Device Tree support to the Nomadik I2C driver >>>>>> >>>>>> Here we apply the bindings required for successful Device Tree >>>>>> probing of the i2c-nomadik driver. We also apply a fall-back >>>>>> configuration in case either one is not provided, or a required >>>>>> element is missing from the one supplied. >>>>>> >>>>>> Cc: linux-i2c@vger.kernel.org >>>>>> Signed-off-by: Lee Jones >>>>>> --- >>>>>> drivers/i2c/busses/i2c-nomadik.c | 82 +++++++++++++++++++++++++++++++++++++- >>>>>> 1 file changed, 80 insertions(+), 2 deletions(-) >>>>>> >>>>>> diff --git a/drivers/i2c/busses/i2c-nomadik.c b/drivers/i2c/busses/i2c-nomadik.c >>>>>> index a92440d..58e8114 100644 >>>>>> --- a/drivers/i2c/busses/i2c-nomadik.c >>>>>> +++ b/drivers/i2c/busses/i2c-nomadik.c >>>>>> @@ -23,6 +23,7 @@ >>>>>> #include >>>>>> #include >>>>>> #include >>>>>> +#include >>>>>> >>>>>> #include >>>>>> >>>>>> @@ -899,15 +900,86 @@ static const struct i2c_algorithm nmk_i2c_algo = { >>>>>> .functionality = nmk_i2c_functionality >>>>>> }; >>>>>> >>>>>> +static struct nmk_i2c_controller u8500_i2c = { >>>>>> + /* >>>>>> + * Slave data setup time; 250ns, 100ns, and 10ns, which >>>>>> + * is 14, 6 and 2 respectively for a 48Mhz i2c clock. >>>>>> + */ >>>>>> + .slsu = 0xe, > > And BTW, I forgot to mention: This slsu stuff is not needed at all. > It is required only in case of slave mode operation, which the > driver does not support. You can perhaps consider deprecating > this parameter from device tree list as well as from platform data. Thanks. I will add it to my TODO list for a latter patch-set. >>>>>> + .tft = 1, /* Tx FIFO threshold */ >>>>>> + .rft = 8, /* Rx FIFO threshold */ >>>>>> + .clk_freq = 100000, /* std. mode operation */ >>>>>> + .timeout = 200, /* Slave response timeout(ms) */ >>>>>> + .sm = I2C_FREQ_MODE_FAST, >>>>> >>>>> How is this possible? you are setting clk_freq as 100kb/s and mode >>>>> as fast mode which is supposed to be 400kb/s. >>>> >>>> That's not how I read it: >>> >>> But it is not readable. It confuses people. >> >> I understood it. :) >> >> If you think it's unclear speak to the author, Linus. He's CC'ed. > > It is! > > /srinidhi -- Lee Jones Linaro ST-Ericsson Landing Team Lead M: +44 77 88 633 515 Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: Fwd: [PATCH 1/3] i2c: Add Device Tree support to the Nomadik I2C driver Date: Fri, 15 Jun 2012 14:58:04 +0100 Message-ID: <4FDB3F6C.9000509@linaro.org> References: <1339428307-3850-10-git-send-email-lee.jones@linaro.org> <4FD8BAD2.50703@linaro.org> <4FDAFA17.6050502@linaro.org> <20120615115042.GA27480@bnru02> <4FDB2E57.4030904@linaro.org> <20120615130544.GA28537@bnru02> <4FDB3642.5030804@linaro.org> <20120615133729.GA12716@bnru02> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20120615133729.GA12716@bnru02> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Srinidhi Kasagar Cc: Linus WALLEIJ , "arnd-r2nGTMty4D4@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-i2c@vger.kernel.org On 15/06/12 14:37, Srinidhi Kasagar wrote: > On Fri, Jun 15, 2012 at 15:18:58 +0200, Lee Jones wrote: >> On 15/06/12 14:05, Srinidhi Kasagar wrote: >>> On Fri, Jun 15, 2012 at 14:45:11 +0200, Lee Jones wrote: >>>> On 15/06/12 12:50, Srinidhi Kasagar wrote: >>>>> [...] >>>>>> >>>>>> >>>>>> From: Lee Jones >>>>>> Date: Tue, 17 Apr 2012 16:04:13 +0100 >>>>>> Subject: [PATCH 1/1] i2c: Add Device Tree support to the Nomadik= I2C driver >>>>>> >>>>>> Here we apply the bindings required for successful Device Tree >>>>>> probing of the i2c-nomadik driver. We also apply a fall-back >>>>>> configuration in case either one is not provided, or a required >>>>>> element is missing from the one supplied. >>>>>> >>>>>> Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >>>>>> Signed-off-by: Lee Jones >>>>>> --- >>>>>> drivers/i2c/busses/i2c-nomadik.c | 82 ++++++++++++++++++++= +++++++++++++++++- >>>>>> 1 file changed, 80 insertions(+), 2 deletions(-) >>>>>> >>>>>> diff --git a/drivers/i2c/busses/i2c-nomadik.c b/drivers/i2c/buss= es/i2c-nomadik.c >>>>>> index a92440d..58e8114 100644 >>>>>> --- a/drivers/i2c/busses/i2c-nomadik.c >>>>>> +++ b/drivers/i2c/busses/i2c-nomadik.c >>>>>> @@ -23,6 +23,7 @@ >>>>>> #include >>>>>> #include >>>>>> #include >>>>>> +#include >>>>>> >>>>>> #include >>>>>> >>>>>> @@ -899,15 +900,86 @@ static const struct i2c_algorithm nmk_i2c_= algo =3D { >>>>>> .functionality =3D nmk_i2c_functionality >>>>>> }; >>>>>> >>>>>> +static struct nmk_i2c_controller u8500_i2c =3D { >>>>>> + /* >>>>>> + * Slave data setup time; 250ns, 100ns, and 10ns, which >>>>>> + * is 14, 6 and 2 respectively for a 48Mhz i2c clock. >>>>>> + */ >>>>>> + .slsu =3D 0xe, > > And BTW, I forgot to mention: This slsu stuff is not needed at all. > It is required only in case of slave mode operation, which the > driver does not support. You can perhaps consider deprecating > this parameter from device tree list as well as from platform data. Thanks. I will add it to my TODO list for a latter patch-set. >>>>>> + .tft =3D 1, /* Tx FIFO threshold */ >>>>>> + .rft =3D 8, /* Rx FIFO threshold */ >>>>>> + .clk_freq =3D 100000, /* std. mode operation */ >>>>>> + .timeout =3D 200, /* Slave response timeout(ms= ) */ >>>>>> + .sm =3D I2C_FREQ_MODE_FAST, >>>>> >>>>> How is this possible? you are setting clk_freq as 100kb/s and mod= e >>>>> as fast mode which is supposed to be 400kb/s. >>>> >>>> That's not how I read it: >>> >>> But it is not readable. It confuses people. >> >> I understood it. :) >> >> If you think it's unclear speak to the author, Linus. He's CC'ed. > > It is! > > /srinidhi --=20 Lee Jones Linaro ST-Ericsson Landing Team Lead M: +44 77 88 633 515 Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Fri, 15 Jun 2012 14:58:04 +0100 Subject: Fwd: [PATCH 1/3] i2c: Add Device Tree support to the Nomadik I2C driver In-Reply-To: <20120615133729.GA12716@bnru02> References: <1339428307-3850-10-git-send-email-lee.jones@linaro.org> <4FD8BAD2.50703@linaro.org> <4FDAFA17.6050502@linaro.org> <20120615115042.GA27480@bnru02> <4FDB2E57.4030904@linaro.org> <20120615130544.GA28537@bnru02> <4FDB3642.5030804@linaro.org> <20120615133729.GA12716@bnru02> Message-ID: <4FDB3F6C.9000509@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 15/06/12 14:37, Srinidhi Kasagar wrote: > On Fri, Jun 15, 2012 at 15:18:58 +0200, Lee Jones wrote: >> On 15/06/12 14:05, Srinidhi Kasagar wrote: >>> On Fri, Jun 15, 2012 at 14:45:11 +0200, Lee Jones wrote: >>>> On 15/06/12 12:50, Srinidhi Kasagar wrote: >>>>> [...] >>>>>> >>>>>> >>>>>> From: Lee Jones >>>>>> Date: Tue, 17 Apr 2012 16:04:13 +0100 >>>>>> Subject: [PATCH 1/1] i2c: Add Device Tree support to the Nomadik I2C driver >>>>>> >>>>>> Here we apply the bindings required for successful Device Tree >>>>>> probing of the i2c-nomadik driver. We also apply a fall-back >>>>>> configuration in case either one is not provided, or a required >>>>>> element is missing from the one supplied. >>>>>> >>>>>> Cc: linux-i2c at vger.kernel.org >>>>>> Signed-off-by: Lee Jones >>>>>> --- >>>>>> drivers/i2c/busses/i2c-nomadik.c | 82 +++++++++++++++++++++++++++++++++++++- >>>>>> 1 file changed, 80 insertions(+), 2 deletions(-) >>>>>> >>>>>> diff --git a/drivers/i2c/busses/i2c-nomadik.c b/drivers/i2c/busses/i2c-nomadik.c >>>>>> index a92440d..58e8114 100644 >>>>>> --- a/drivers/i2c/busses/i2c-nomadik.c >>>>>> +++ b/drivers/i2c/busses/i2c-nomadik.c >>>>>> @@ -23,6 +23,7 @@ >>>>>> #include >>>>>> #include >>>>>> #include >>>>>> +#include >>>>>> >>>>>> #include >>>>>> >>>>>> @@ -899,15 +900,86 @@ static const struct i2c_algorithm nmk_i2c_algo = { >>>>>> .functionality = nmk_i2c_functionality >>>>>> }; >>>>>> >>>>>> +static struct nmk_i2c_controller u8500_i2c = { >>>>>> + /* >>>>>> + * Slave data setup time; 250ns, 100ns, and 10ns, which >>>>>> + * is 14, 6 and 2 respectively for a 48Mhz i2c clock. >>>>>> + */ >>>>>> + .slsu = 0xe, > > And BTW, I forgot to mention: This slsu stuff is not needed at all. > It is required only in case of slave mode operation, which the > driver does not support. You can perhaps consider deprecating > this parameter from device tree list as well as from platform data. Thanks. I will add it to my TODO list for a latter patch-set. >>>>>> + .tft = 1, /* Tx FIFO threshold */ >>>>>> + .rft = 8, /* Rx FIFO threshold */ >>>>>> + .clk_freq = 100000, /* std. mode operation */ >>>>>> + .timeout = 200, /* Slave response timeout(ms) */ >>>>>> + .sm = I2C_FREQ_MODE_FAST, >>>>> >>>>> How is this possible? you are setting clk_freq as 100kb/s and mode >>>>> as fast mode which is supposed to be 400kb/s. >>>> >>>> That's not how I read it: >>> >>> But it is not readable. It confuses people. >> >> I understood it. :) >> >> If you think it's unclear speak to the author, Linus. He's CC'ed. > > It is! > > /srinidhi -- Lee Jones Linaro ST-Ericsson Landing Team Lead M: +44 77 88 633 515 Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog