From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47561) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SfZk9-0007gv-RB for qemu-devel@nongnu.org; Fri, 15 Jun 2012 12:51:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SfZk7-0003b5-W8 for qemu-devel@nongnu.org; Fri, 15 Jun 2012 12:51:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:19822) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SfZk7-0003ay-O1 for qemu-devel@nongnu.org; Fri, 15 Jun 2012 12:51:27 -0400 Message-ID: <4FDB680A.5060200@redhat.com> Date: Fri, 15 Jun 2012 10:51:22 -0600 From: Eric Blake MIME-Version: 1.0 References: <1339772759-31004-1-git-send-email-pbonzini@redhat.com> <1339772759-31004-3-git-send-email-pbonzini@redhat.com> In-Reply-To: <1339772759-31004-3-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig0484632DCD635D618D92F399" Subject: Re: [Qemu-devel] [RFC PATCH 02/36] qerror/block: introduce QERR_BLOCK_JOB_NOT_ACTIVE List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, lcapitulino@redhat.com, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig0484632DCD635D618D92F399 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/15/2012 09:05 AM, Paolo Bonzini wrote: > The DeviceNotActive error is not a particularly good match, add > a separate one. >=20 > Signed-off-by: Paolo Bonzini > --- > blockdev.c | 4 ++-- > qapi-schema.json | 5 ++--- > qerror.c | 4 ++++ > qerror.h | 3 +++ > 4 files changed, 11 insertions(+), 5 deletions(-) Looks reasonable, but it will affect libvirt: Right now, libvirt parses the particular return code (qemu_monitor.c:qemuMonitorJSONBlockJob), and translates DeviceNotActive =3D> "No active operation on device" =2E.. all others =3D> "Unexpected error" so if this patch goes in but libvirt doesn't match, then libvirt will have a regression in error message quality. Not the end of the world, though, so don't hold back just because of libvirt. Reviewed-by: Eric Blake > @@ -1679,8 +1679,7 @@ > # @device: the device name > # > # Returns: Nothing on success > -# If no background operation is active on this device, Device= NotActive > -# If cancellation already in progress, DeviceInUse > +# If no background operation is active on this device, BlockJ= obNotActive What happened to DeviceInUse? --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig0484632DCD635D618D92F399 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJP22gKAAoJEKeha0olJ0Nq0+0H/jIlFRtYKtzyOycfMBfHXQEl XSoRdEys8NeaDzkh29GqtyghaMEDXZRXvndNw10VBeOLXNtv+T46mz6k4lxGVgF3 Ah/t7UfZ1TTEPQfUFVjWuwTGOZsdhRCajlH8A2A1/JdD0ZN6G374OykJqWfF0Xio 5PFEym0eBm7cuiHO/uZo3faA/OGgBtWX354iH4xdkazf9qccN2yWIe+kqOd+fDiR pqhM51hFGl6pK85CwcFIKbWhPoZzkF8bOn3cZDV5A9d1/85pRcvfbeM3GrYmpHkc 7G7Qt44zt8meb8i7zURrA21ivn8dxqKsqjkIJZabZp1NnIVWHdYNrxZU2s9vF9g= =aruR -----END PGP SIGNATURE----- --------------enig0484632DCD635D618D92F399--