From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57903) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SfaEQ-0004Of-18 for qemu-devel@nongnu.org; Fri, 15 Jun 2012 13:22:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SfaEO-0007Wb-1r for qemu-devel@nongnu.org; Fri, 15 Jun 2012 13:22:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:13324) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SfaEN-0007WE-Q9 for qemu-devel@nongnu.org; Fri, 15 Jun 2012 13:22:43 -0400 Message-ID: <4FDB6F5F.8050505@redhat.com> Date: Fri, 15 Jun 2012 11:22:39 -0600 From: Eric Blake MIME-Version: 1.0 References: <1339772759-31004-1-git-send-email-pbonzini@redhat.com> <1339772759-31004-6-git-send-email-pbonzini@redhat.com> In-Reply-To: <1339772759-31004-6-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig8299198905F16F40FBCFD62A" Subject: Re: [Qemu-devel] [RFC PATCH 05/36] block: add support for job pause/resume List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, lcapitulino@redhat.com, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig8299198905F16F40FBCFD62A Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/15/2012 09:05 AM, Paolo Bonzini wrote: > Job pausing reuses the existing support for cancellable sleeps. A paus= e > happens at the next sleeping point and lasts until the coroutine is > re-entered explicitly. Cancellation was already doing a forced resume,= > so implement it explicitly in terms of resume. >=20 > Paused jobs cannot be canceled without first resuming them. This ensur= es > that I/O errors are never missed by management. >=20 > +++ b/qapi-schema.json > @@ -906,6 +906,8 @@ > # > # @len: the maximum progress value > # > +# @paused: whether the job is paused > +# > # @offset: the current progress value > # > # @speed: the rate limit, bytes per second > @@ -914,7 +916,7 @@ > ## > { 'type': 'BlockJobInfo', > 'data': {'type': 'str', 'device': 'str', 'len': 'int', > - 'offset': 'int', 'speed': 'int'} } > + 'offset': 'int', 'paused': 'bool', 'speed': 'int'} } Should this be listed as '*paused': 'bool', as an indication that not all versions of qemu populated the paused member? It's an output-only type, though, so I think we are okay in providing more information that what clients were previously used to seeing. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig8299198905F16F40FBCFD62A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJP229gAAoJEKeha0olJ0NqSh0H/3/q1j1jhO2ZeC6qCPMamanl 0QkSryN4rO+EUBNix5fsjmalD8VyVlHfgwohu6AF/Pi1viPe+Xl2hJDJFHPwxlGF os4hS3jBOESFj5KhzIvfCzBn1Nd8Bav3IHoBWOS1OJulj4Oh1W+ajfwyYsdkjQht 2GfMKCLdzd2FN1LoZiA+jP0LmARm0ECOU3+xFJ72nwMDP5B93L/BQ7jPDzex7KBB enIuiF0URqNYrABqfpdHYJfR03sO0MveuPKwGMYAP+dUV0zWwJ/PCIZV/FqRpyZh Oi2FpybLC77k8gPfyFu921I5FARed2x4yc7s3WdKpcIKzS6K8W3oB5ZoMeGgOdo= =9MrK -----END PGP SIGNATURE----- --------------enig8299198905F16F40FBCFD62A--