From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46190) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sfdoh-0005Pa-NU for qemu-devel@nongnu.org; Fri, 15 Jun 2012 17:12:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sfdof-0008K5-VS for qemu-devel@nongnu.org; Fri, 15 Jun 2012 17:12:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32707) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sfdof-0008Jv-NK for qemu-devel@nongnu.org; Fri, 15 Jun 2012 17:12:25 -0400 Message-ID: <4FDBA535.7000008@redhat.com> Date: Fri, 15 Jun 2012 15:12:21 -0600 From: Eric Blake MIME-Version: 1.0 References: <1339772759-31004-1-git-send-email-pbonzini@redhat.com> <1339772759-31004-26-git-send-email-pbonzini@redhat.com> In-Reply-To: <1339772759-31004-26-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigC85B852A4C8A001CDCB44423" Subject: Re: [Qemu-devel] [RFC PATCH 25/36] mirror: add support for on_source_error/on_target_error List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, lcapitulino@redhat.com, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigC85B852A4C8A001CDCB44423 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/15/2012 09:05 AM, Paolo Bonzini wrote: > (Mostly untested). >=20 > Signed-off-by: Paolo Bonzini > --- > block/mirror.c | 50 +++++++++++++++++++++++++++++++++++++++++-----= ---- > block_int.h | 4 ++++ > blockdev.c | 14 ++++++++++++-- > hmp.c | 3 ++- > qapi-schema.json | 7 ++++++- > qmp-commands.hx | 8 +++++++- > 6 files changed, 72 insertions(+), 14 deletions(-) > +++ b/qapi-schema.json > @@ -1379,6 +1379,10 @@ > # (all the disk, only the sectors allocated in the topmost imag= e, or > # only new I/O). > # > +# @on_source_error: #optional the action to take on an error on the so= urce > +# > +# @on_target_error: #optional the action to take on an error on the ta= rget Mention the default when not provided. > +# > # Returns: nothing on success > # If @device is not a valid block device, DeviceNotFound > # If @target can't be opened, OpenFileFailed > @@ -1389,7 +1393,8 @@ > { 'command': 'drive-mirror', > 'data': { 'device': 'str', 'target': 'str', '*format': 'str', > 'sync': 'MirrorSyncMode', '*mode': 'NewImageMode', > - '*speed': 'int' } } > + '*speed': 'int', '*on_source_error': 'BlockdevOnError', > + '*on_target_error': 'BlockdevOnError' } } QMP should prefer - over _; shouldn't this be '*on-source-error' and '*on-target-error'? --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigC85B852A4C8A001CDCB44423 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJP26U1AAoJEKeha0olJ0NqwOQH+gKdgeQAiO14eqqkEXe2PSJ+ Ec3kfCgjKwQrPWw08ipwzHpF5+S/ijqwp9efMd9F2VCJ3nbQ+SRnaSg2H/NxdzFM c5VeA4CrRlj5cNCCNbg4ZbuXUVeg/NtB0qtKo9eluIVOTwMDoUlHrVHGvACJUbxm AUDCJym3wCXBHMloGJKcxhAJJBtP6QVvhrwd/DNW1CIVRkdUN3LAwIhYIEmAfS0W olK2csDLSLBuk7ss67mP+mFsAKlvGjN/g7V8A6KIGfOSxiDjq4YMkVi98Tg/ZZRB wGPojyv6QWwBlPQo2H8AWzCp1FjDdRAd366pMDZej+2IreFjaoy3Cl93jnS4BgE= =Tqyk -----END PGP SIGNATURE----- --------------enigC85B852A4C8A001CDCB44423--