From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35782) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SfdrE-0006Nk-0J for qemu-devel@nongnu.org; Fri, 15 Jun 2012 17:15:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SfdrC-0000Vd-6h for qemu-devel@nongnu.org; Fri, 15 Jun 2012 17:15:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36815) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SfdrB-0000UM-Uh for qemu-devel@nongnu.org; Fri, 15 Jun 2012 17:15:02 -0400 Message-ID: <4FDBA5D2.5020209@redhat.com> Date: Fri, 15 Jun 2012 15:14:58 -0600 From: Eric Blake MIME-Version: 1.0 References: <1339772759-31004-1-git-send-email-pbonzini@redhat.com> <1339772759-31004-27-git-send-email-pbonzini@redhat.com> In-Reply-To: <1339772759-31004-27-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigEC00E8A3B4B18EDB328928B0" Subject: Re: [Qemu-devel] [RFC PATCH 26/36] block: live snapshot documentation tweaks List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, lcapitulino@redhat.com, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigEC00E8A3B4B18EDB328928B0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/15/2012 09:05 AM, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > qapi-schema.json | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/qapi-schema.json b/qapi-schema.json > index 2ee988b..250edf2 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -1289,6 +1289,7 @@ > # > # Returns: nothing on success > # If @device is not a valid block device, DeviceNotFound > +# If the block device has no medium inserted, DeviceHasNoMedi= um > # If @device is busy, DeviceInUse will be returned > # If @snapshot-file can't be created, OpenFileFailed > # If @snapshot-file can't be opened, OpenFileFailed Can we combine these? If @snapshot-file can't be opened or created, OpenFileFailed > @@ -1321,6 +1322,9 @@ > # > # Returns: nothing on success > # If @device is not a valid block device, DeviceNotFound > +# If the block device has no medium inserted, DeviceHasNoMedi= um > +# If @device is busy, DeviceInUse will be returned > +# If @snapshot-file can't be created, OpenFileFailed > # If @snapshot-file can't be opened, OpenFileFailed and again. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigEC00E8A3B4B18EDB328928B0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJP26XSAAoJEKeha0olJ0NqkiYIAIcrauvUhpK4mqM0pxAjNEtr LXOV+En76j2QVpp+rZoQG8Kkw3gXx7tMFoX2k5bIhnwAw6t1ZMXByfLojUe2oXRX eAojDB5gBPjlmDhdbTH8nC2F8kdskxc5GjRroEIDwhiiFGVJj49VQPuz1U+78SEz j2kNInik/MLLokc17fi71dY7XzkBo1TcI9/Vz0HgzKiRNzmDMD9J7ueN04S0r4hw SeVCaG/mkHoSvHHCOLiOT6G8JlsjAZeuzOYL3RqwKHcx0CA6mXdiJvXYSijiosc+ NIBNtPJjUUVvxkkjxWJYx0vTvAP/DogCHo/XeFrqNdJQUvcS9b3/gYBrzmaCjmk= =13nL -----END PGP SIGNATURE----- --------------enigEC00E8A3B4B18EDB328928B0--