From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ShFu6-0002pf-Gz for mharc-grub-devel@gnu.org; Wed, 20 Jun 2012 04:04:42 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45847) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ShFu3-0002pT-HS for grub-devel@gnu.org; Wed, 20 Jun 2012 04:04:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ShFu1-0005DS-PN for grub-devel@gnu.org; Wed, 20 Jun 2012 04:04:39 -0400 Received: from qmta05.westchester.pa.mail.comcast.net ([76.96.62.48]:35081) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ShFu1-0005DD-LR for grub-devel@gnu.org; Wed, 20 Jun 2012 04:04:37 -0400 Received: from omta16.westchester.pa.mail.comcast.net ([76.96.62.88]) by qmta05.westchester.pa.mail.comcast.net with comcast id QXyS1j0031uE5Es55Y4bAj; Wed, 20 Jun 2012 08:04:35 +0000 Received: from [192.168.1.101] ([24.63.69.222]) by omta16.westchester.pa.mail.comcast.net with comcast id QY4c1j0014nkFao3cY4cuj; Wed, 20 Jun 2012 08:04:36 +0000 Message-ID: <4FE18412.30109@comcast.net> Date: Wed, 20 Jun 2012 04:04:34 -0400 From: Robert Mabee User-Agent: Mozilla/5.0 (X11; Linux i686; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: grub-devel@gnu.org Subject: Re: [PATCH] '.' causes wildcard expansion References: <4FD59694.3080600@comcast.net> <4FD91756.9080200@comcast.net> <4FE06E5F.5050204@gmail.com> In-Reply-To: <4FE06E5F.5050204@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 76.96.62.48 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jun 2012 08:04:41 -0000 On 06/19/2012 08:19 AM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > I've fixed these problems AFAICT now. Can you confirm? I agree that many extraneous regex chars are now properly quoted so no more functionality is exposed than is intended, now * and ?. I suggest also quoting ^ and $ just for completeness. I can not explain why @ is quoted; it's not mentioned in the documentation for POSIX-compatible regex or in gnulib/regcomp.c. wildcard_escape in script/execute.c quotes the wild chars and [ , which is no longer wild. This can lead to a surprising extra level of quoting, so for example *'['* becomes the useless regexp pattern ^.*\\\[.*$ It appears the only remaining use of isregexop is in make_dir, which removes \ quoting only before regex chars, from path components that weren't wild. If this quoting was inserted by wildcard_escape then it should be removed similarly to wildcard_unescape, which doesn't examine the quoted char.