From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40125) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ShMnr-00041u-LL for qemu-devel@nongnu.org; Wed, 20 Jun 2012 11:26:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ShMnl-000242-EU for qemu-devel@nongnu.org; Wed, 20 Jun 2012 11:26:43 -0400 Received: from e35.co.us.ibm.com ([32.97.110.153]:56716) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ShMnl-00023K-7v for qemu-devel@nongnu.org; Wed, 20 Jun 2012 11:26:37 -0400 Received: from /spool/local by e35.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 20 Jun 2012 09:26:33 -0600 Received: from d03relay05.boulder.ibm.com (d03relay05.boulder.ibm.com [9.17.195.107]) by d03dlp02.boulder.ibm.com (Postfix) with ESMTP id ADCBC3E40250 for ; Wed, 20 Jun 2012 15:24:29 +0000 (WET) Received: from d03av06.boulder.ibm.com (d03av06.boulder.ibm.com [9.17.195.245]) by d03relay05.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q5KFM53q204294 for ; Wed, 20 Jun 2012 09:22:14 -0600 Received: from d03av06.boulder.ibm.com (loopback [127.0.0.1]) by d03av06.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q5KFLl8P011337 for ; Wed, 20 Jun 2012 09:21:47 -0600 Message-ID: <4FE1EA51.2080809@us.ibm.com> Date: Wed, 20 Jun 2012 10:20:49 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1340203444-20394-1-git-send-email-aliguori@us.ibm.com> <4FE1E355.3010102@suse.de> In-Reply-To: <4FE1E355.3010102@suse.de> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH] build: introduce target CONFIG_ variables and use them for kvm List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Andreas_F=E4rber?= Cc: Paolo Bonzini , qemu-devel@nongnu.org, Peter Maydell On 06/20/2012 09:51 AM, Andreas Färber wrote: > Am 20.06.2012 16:44, schrieb Anthony Liguori: >> diff --git a/hw/kvm/Makefile.objs b/hw/kvm/Makefile.objs >> index 226497a..cf734ba 100644 >> --- a/hw/kvm/Makefile.objs >> +++ b/hw/kvm/Makefile.objs >> @@ -1 +1 @@ >> -obj-$(CONFIG_KVM) += clock.o apic.o i8259.o ioapic.o i8254.o >> +obj-$(CONFIG_I386) += clock.o apic.o i8259.o ioapic.o i8254.o > > NACK. As long as the CPUState conversion is not completed (which after > part 4 will take some time still) any user of CPUArchState must be > compiled per target, not per base target. It may or may not work > depending on fields accessed, but it is architecturally wrong. It's admittedly confusing. obj-y => this is built per-target (there is no concept of per-base target) hw-obj-y => this is built once for 32-bit, once for 64-bit common-obj-y => this is built once for all targets CONFIG_I386=y if target arch == i386 or base arch == i386. Regards. Anthony Liguori > > Andreas >