All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Budig <simon.budig@kernelconcepts.de>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Henrik Rydberg <rydberg@euromail.se>,
	Olivier Sobrie <olivier@sobrie.be>,
	linux-input@vger.kernel.org,
	Jan Paesmans <jan.paesmans@gmail.com>,
	Anatolij Gustshin <agust@denx.de>, Ilya Yanok <yanok@emcraft.com>
Subject: Re: [PATCH] input: edt-ft5x06 - Touchscreen driver for FT5x06 based EDT displays
Date: Thu, 21 Jun 2012 11:39:24 +0200	[thread overview]
Message-ID: <4FE2EBCC.2020108@kernelconcepts.de> (raw)
In-Reply-To: <20120621083940.GA2193@core.coreip.homeip.net>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 06/21/2012 10:39 AM, Dmitry Torokhov wrote:
>> Anyway. I have reviewed the changes Dmitry suggested and will
>> test them on real hardware tomorrow.

Ok, the bad news is, that it doesn't work with your changes. There was
one oops I was able to resolve (i2c_set_clientdata must happen before
sysfs_create_group) but the touch also failed to deliver input events
and mode switching doesn't work.

I'll try to incorporate your patch incrementally, but this might have
to wait for the weekend.

> That would be great as I already reviewed your version. If there
> is something missing from your version that is present in Olivier,
> I woudl prefer getting an incremental patch.

One thing Olivier did which is not in my patch is, that he used the
type B protocol while I am still on type A. This is something I could
change.

Bye,
        Simon

- -- 
       Simon Budig                        kernel concepts GmbH
       simon.budig@kernelconcepts.de      Sieghuetter Hauptweg 48
       +49-271-771091-17                  D-57072 Siegen

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk/i68wACgkQO2O/RXesiHA/hwCfQEZDL+KukaCsKpMMRdpuPfo2
FQQAnRqAtrPoAmLDeQ5bonidXMSlrtMk
=DPlX
-----END PGP SIGNATURE-----

  reply	other threads:[~2012-06-21  9:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-14 11:01 [PATCH] input: edt-ft5x06 - Touchscreen driver for FT5x06 based EDT displays Olivier Sobrie
2012-06-14 12:05 ` Simon Budig
2012-06-14 12:48   ` Olivier Sobrie
2012-06-20 18:40 ` Henrik Rydberg
2012-06-20 21:27   ` Simon Budig
2012-06-21  8:39     ` Dmitry Torokhov
2012-06-21  9:39       ` Simon Budig [this message]
2012-06-21 10:04         ` Dmitry Torokhov
2012-06-21 14:53           ` Simon Budig
2012-06-25  7:23             ` Dmitry Torokhov
2012-06-21  6:35   ` Olivier Sobrie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FE2EBCC.2020108@kernelconcepts.de \
    --to=simon.budig@kernelconcepts.de \
    --cc=agust@denx.de \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jan.paesmans@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=olivier@sobrie.be \
    --cc=rydberg@euromail.se \
    --cc=yanok@emcraft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.