From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Henningsson Subject: Re: [RFC PATCH] Inverted internal mic Date: Fri, 22 Jun 2012 17:27:51 +0200 Message-ID: <4FE48EF7.6060101@canonical.com> References: <4F4C9714.1080307@canonical.com> <4F4CA438.90103@canonical.com> <4F4CD1AF.2050409@canonical.com> <4F4CE264.7040008@canonical.com> <4FE02D8B.7050201@canonical.com> <4FE275AF.4080004@canonical.com> <4FE31BEC.20708@canonical.com> <4FE32E74.1040902@canonical.com> <4FE44D1F.1060903@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by alsa0.perex.cz (Postfix) with ESMTP id 17567103FAE for ; Fri, 22 Jun 2012 17:27:45 +0200 (CEST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Takashi Iwai Cc: alsa-devel@alsa-project.org, Eliot Blennerhassett List-Id: alsa-devel@alsa-project.org On 06/22/2012 02:46 PM, Takashi Iwai wrote: > /* > + * Inverted digital-mic handling > + * > + * First off, it's a bit tricky. The "Inverted Internal Mic Capture Switch" > + * gives the additional mute only to the right channel of the digital mic > + * capture stream. This is a workaround for avoiding the almost silence > + * by summing the stereo stereo stream from some (known to be ForteMedia) Stereo stereo? It's "stereo" in stereo! :-) > + * digital mic unit. > + * > + * The logic is to call alc_inv_dmic_sync() after each action (possibly) > + * modifying ADC amp. When the mute flag is set, it mutes the R-channel > + * without caching so that the cache can still keep the original value. > + * The cached value is then restored when the flag is set off or any other > + * than d-mic is used as the current input source. Ok, I get it now. There is a slight drawback with this (IMO a bit hacky) patch, and that is that you can get a short signal spike on the right channel when you turn "Capture Switch" on while "Inverted Capture" is off. Hopefully it is not a practical problem. Thanks for looking at this long-standing problem :-) -- David Henningsson, Canonical Ltd. https://launchpad.net/~diwic