From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laxman Dewangan Subject: Re: [PATCH 1/3] ARM: dt: tegra: seaboard: add regulators Date: Mon, 25 Jun 2012 11:54:19 +0530 Message-ID: <4FE80413.6070001@nvidia.com> References: <1340406842-27135-1-git-send-email-swarren@wwwdotorg.org> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1340406842-27135-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Stephen Warren Cc: Olof Johansson , Colin Cross , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Stephen Warren , Mark Brown List-Id: linux-tegra@vger.kernel.org On Saturday 23 June 2012 04:44 AM, Stephen Warren wrote: > From: Stephen Warren > > Seaboard uses a TPS6586x regulator. Instantiate this, and hook up a > couple of fixed GPIO-controlled regulators too. > > The regulator configurations were mostly taken from the ChromeOS 3.2 > kernel. Exceptions are: > > * The schematic lists a fixed voltage for each rail, whereas the ChromeOS > kernel lists a range for many rails. I used the values from the ChromeOS > kernel in all cases, since I know the board file there is the most > complete available for this hardware. > > * The vdd_1v2 fixed regulator is present only in the schematic. So, I added > this based on the schematic. > > * A 3.3v fixed regulator using GPIO3 of the TPS6586x is present in the > ChromeOS kernel, but not in the schematic. So, I dropped this based on > the schematic. > > Signed-off-by: Stephen Warren > --- Acked-by: Laxman Dewangan I think this series very much depends on the series [PATCH V3 0/3] regulator: dt: add policy to match regulator with prop "regulator-compatible" > + regulator@3 { > + reg =<3>; > + regulator-compatible = "ldo0"; > + regulator-name = "vdd_ldo0"; > + regulator-min-microvolt =<1250000>; > + regulator-max-microvolt =<3300000>; > + vin-supply =<&sm2_reg>; I think support for vin-supply is still not there for this regulator in driver. From mboxrd@z Thu Jan 1 00:00:00 1970 From: ldewangan@nvidia.com (Laxman Dewangan) Date: Mon, 25 Jun 2012 11:54:19 +0530 Subject: [PATCH 1/3] ARM: dt: tegra: seaboard: add regulators In-Reply-To: <1340406842-27135-1-git-send-email-swarren@wwwdotorg.org> References: <1340406842-27135-1-git-send-email-swarren@wwwdotorg.org> Message-ID: <4FE80413.6070001@nvidia.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Saturday 23 June 2012 04:44 AM, Stephen Warren wrote: > From: Stephen Warren > > Seaboard uses a TPS6586x regulator. Instantiate this, and hook up a > couple of fixed GPIO-controlled regulators too. > > The regulator configurations were mostly taken from the ChromeOS 3.2 > kernel. Exceptions are: > > * The schematic lists a fixed voltage for each rail, whereas the ChromeOS > kernel lists a range for many rails. I used the values from the ChromeOS > kernel in all cases, since I know the board file there is the most > complete available for this hardware. > > * The vdd_1v2 fixed regulator is present only in the schematic. So, I added > this based on the schematic. > > * A 3.3v fixed regulator using GPIO3 of the TPS6586x is present in the > ChromeOS kernel, but not in the schematic. So, I dropped this based on > the schematic. > > Signed-off-by: Stephen Warren > --- Acked-by: Laxman Dewangan I think this series very much depends on the series [PATCH V3 0/3] regulator: dt: add policy to match regulator with prop "regulator-compatible" > + regulator at 3 { > + reg =<3>; > + regulator-compatible = "ldo0"; > + regulator-name = "vdd_ldo0"; > + regulator-min-microvolt =<1250000>; > + regulator-max-microvolt =<3300000>; > + vin-supply =<&sm2_reg>; I think support for vin-supply is still not there for this regulator in driver.