All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Marek <mmarek@suse.cz>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: linux-kbuild <linux-kbuild@vger.kernel.org>,
	lkml <linux-kernel@vger.kernel.org>,
	Artem Bityutskiy <dedekind1@gmail.com>
Subject: Re: [PATCH 7/8] kbuild: move W=... stuff to Kbuild.arch
Date: Tue, 26 Jun 2012 12:37:41 +0200	[thread overview]
Message-ID: <4FE990F5.1020500@suse.cz> (raw)
In-Reply-To: <1336205926-13946-7-git-send-email-sam@ravnborg.org>

On 5.5.2012 10:18, Sam Ravnborg wrote:
> Prevent that we eveluate cc-option multiple times for the same
> option by moving the definitions to Kbuild.arch.
> The file is included once only, thus gcc is not invoked once per directory.

Nice.


> Another side-effect of this patch is that KCFLAGS are appended last
> to the list of options. This allows us to better control the options.
> Artem Bityutskiy <dedekind1@gmail.com> noticed this.
> 
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Artem Bityutskiy <dedekind1@gmail.com>
> ---
>  scripts/Kbuild.arch    |   51 +++++++++++++++++++++++++++++++++++++++++++++++-
>  scripts/Makefile.build |   51 ------------------------------------------------
>  2 files changed, 50 insertions(+), 52 deletions(-)
> 
> diff --git a/scripts/Kbuild.arch b/scripts/Kbuild.arch
> index 230050f..6ff27c6 100644
> --- a/scripts/Kbuild.arch
> +++ b/scripts/Kbuild.arch
> @@ -76,6 +76,56 @@ ifeq ($(shell $(CONFIG_SHELL) $(srctree)/scripts/gcc-goto.sh $(CC)), y)
>          KBUILD_CFLAGS += -DCC_HAVE_ASM_GOTO
>  endif
>  
> +# make W=... settings

Again a nitpick only, in the comment earlier in this file

# This warning generated too much noise in a regular build.
# Use make W=1 to enable this warning (see scripts/Makefile.build)

the scripts/Makefile.build reference lost its meaning now.

Michal

  parent reply	other threads:[~2012-06-26 10:37 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-05  8:06 [PATCH 0/8] kbuild: use script for final link, move definitions out of top-level Makefile Sam Ravnborg
2012-05-05  8:18 ` [PATCH 1/8] kbuild: drop unused KBUILD_VMLINUX_OBJS from " Sam Ravnborg
2012-05-05  8:18 ` [PATCH 2/8] kbuild: refactor final link of sparc32 Sam Ravnborg
2012-05-05  8:18 ` [PATCH 3/8] kbuild: link of vmlinux moved to a script Sam Ravnborg
2012-05-05  8:18 ` [PATCH 4/8] kbuild: document KBUILD_LDS, KBUILD_VMLINUX_{INIT,MAIN} and LDFLAGS_vmlinux Sam Ravnborg
2012-05-05  8:18 ` [PATCH 5/8] kbuild: move definitions from top-level Makefile to scripts/Kbuild.config Sam Ravnborg
2012-06-26  9:37   ` Michal Marek
2012-06-26 10:18   ` Michal Marek
2012-05-05  8:18 ` [PATCH 6/8] kbuild: move arch definitions from top-level Makefile to scripts/Kbuild.arch Sam Ravnborg
2012-06-26 10:33   ` Michal Marek
2012-05-05  8:18 ` [PATCH 7/8] kbuild: move W=... stuff to Kbuild.arch Sam Ravnborg
2012-05-05  9:51   ` Artem Bityutskiy
2012-06-06 10:18   ` Artem Bityutskiy
2012-06-06 15:35     ` Sam Ravnborg
2012-06-06 15:46       ` Artem Bityutskiy
2012-08-15  9:41       ` Artem Bityutskiy
2012-08-15 10:17         ` Sam Ravnborg
2012-06-26 10:37   ` Michal Marek [this message]
2012-05-05  8:18 ` [PATCH 8/8] kbuild: remove useless warning Sam Ravnborg
2012-05-07  6:59   ` Artem Bityutskiy
2012-06-26 10:40   ` Michal Marek
2012-05-05 19:28 ` [PATCH 0/8] kbuild: use script for final link, move definitions out of top-level Makefile Michal Marek
2012-05-05 21:03   ` Sam Ravnborg
2012-05-16  4:52   ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FE990F5.1020500@suse.cz \
    --to=mmarek@suse.cz \
    --cc=dedekind1@gmail.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.