From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758452Ab2FZPc3 (ORCPT ); Tue, 26 Jun 2012 11:32:29 -0400 Received: from mx2.parallels.com ([64.131.90.16]:48441 "EHLO mx2.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757161Ab2FZPc2 (ORCPT ); Tue, 26 Jun 2012 11:32:28 -0400 Message-ID: <4FE9D568.4050802@parallels.com> Date: Tue, 26 Jun 2012 19:29:44 +0400 From: Glauber Costa User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 MIME-Version: 1.0 To: Andrew Morton CC: , , , Frederic Weisbecker , David Rientjes , Pekka Enberg , Michal Hocko , Johannes Weiner , Christoph Lameter , , , Tejun Heo , Pekka Enberg Subject: Re: [PATCH 06/11] memcg: kmem controller infrastructure References: <1340633728-12785-1-git-send-email-glommer@parallels.com> <1340633728-12785-7-git-send-email-glommer@parallels.com> <20120625161720.ae13ae90.akpm@linux-foundation.org> In-Reply-To: <20120625161720.ae13ae90.akpm@linux-foundation.org> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/26/2012 03:17 AM, Andrew Morton wrote: >> + if (ret == -EINTR) { >> >+ nofail = true; >> >+ /* >> >+ * __mem_cgroup_try_charge() chose to bypass to root due >> >+ * to OOM kill or fatal signal. > Is "bypass" correct? Maybe "fall back"? > Heh, forgot this one, sorry =( __mem_cgroup_try_charge does "goto bypass", so I believe the term "bypass" is better to allow whoever is following this code to follow it. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx161.postini.com [74.125.245.161]) by kanga.kvack.org (Postfix) with SMTP id DC2CE6B005A for ; Tue, 26 Jun 2012 11:32:26 -0400 (EDT) Message-ID: <4FE9D568.4050802@parallels.com> Date: Tue, 26 Jun 2012 19:29:44 +0400 From: Glauber Costa MIME-Version: 1.0 Subject: Re: [PATCH 06/11] memcg: kmem controller infrastructure References: <1340633728-12785-1-git-send-email-glommer@parallels.com> <1340633728-12785-7-git-send-email-glommer@parallels.com> <20120625161720.ae13ae90.akpm@linux-foundation.org> In-Reply-To: <20120625161720.ae13ae90.akpm@linux-foundation.org> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton Cc: cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Frederic Weisbecker , David Rientjes , Pekka Enberg , Michal Hocko , Johannes Weiner , Christoph Lameter , devel@openvz.org, kamezawa.hiroyu@jp.fujitsu.com, Tejun Heo , Pekka Enberg On 06/26/2012 03:17 AM, Andrew Morton wrote: >> + if (ret == -EINTR) { >> >+ nofail = true; >> >+ /* >> >+ * __mem_cgroup_try_charge() chose to bypass to root due >> >+ * to OOM kill or fatal signal. > Is "bypass" correct? Maybe "fall back"? > Heh, forgot this one, sorry =( __mem_cgroup_try_charge does "goto bypass", so I believe the term "bypass" is better to allow whoever is following this code to follow it. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: Glauber Costa Subject: Re: [PATCH 06/11] memcg: kmem controller infrastructure Date: Tue, 26 Jun 2012 19:29:44 +0400 Message-ID: <4FE9D568.4050802@parallels.com> References: <1340633728-12785-1-git-send-email-glommer@parallels.com> <1340633728-12785-7-git-send-email-glommer@parallels.com> <20120625161720.ae13ae90.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120625161720.ae13ae90.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Andrew Morton Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Frederic Weisbecker , David Rientjes , Pekka Enberg , Michal Hocko , Johannes Weiner , Christoph Lameter , devel-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org, kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org, Tejun Heo , Pekka Enberg On 06/26/2012 03:17 AM, Andrew Morton wrote: >> + if (ret == -EINTR) { >> >+ nofail = true; >> >+ /* >> >+ * __mem_cgroup_try_charge() chose to bypass to root due >> >+ * to OOM kill or fatal signal. > Is "bypass" correct? Maybe "fall back"? > Heh, forgot this one, sorry =( __mem_cgroup_try_charge does "goto bypass", so I believe the term "bypass" is better to allow whoever is following this code to follow it.