From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Hui Wang <jason77.wang@gmail.com>
Cc: davem@davemloft.net, shawn.guo@linaro.org, linux-can@vger.kernel.org
Subject: Re: [PATCH 3/4] can: flexcan: add ipg and ser clocks support
Date: Wed, 27 Jun 2012 10:45:21 +0200 [thread overview]
Message-ID: <4FEAC821.4070604@pengutronix.de> (raw)
In-Reply-To: <1340785161-3598-4-git-send-email-jason77.wang@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 883 bytes --]
On 06/27/2012 10:19 AM, Hui Wang wrote:
> Some i.MX chip (like i.MX6) has two clocks to drive flexcan module,
> one is ipg clock, another is serial clock, if we want the flexcan
> to work, we need to enable both two clocks, but current driver only
> support one clock.
>
> My modification doesn't break existing platforms. For those without
> clocks (like powerpc platforms), two clk pointers are set to NULL as
> before, for those only have one clock (like i.MX25 and i.MX35), the
> second clk pointer is set to NULL.
Looks good at the first sight. Will test on hardware later.
Tnx, Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
next prev parent reply other threads:[~2012-06-27 8:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-27 8:19 [PATCH 0/4] can: flexcan: upgrade the flexcan.c to support i.MX6 Hui Wang
2012-06-27 8:19 ` [PATCH 1/4] can: flexcan: use be32_to_cpup to handle the value of dt entry Hui Wang
2012-06-27 8:19 ` [PATCH 2/4] can: flexcan: add hardware controller version support Hui Wang
2012-06-27 8:19 ` [PATCH 3/4] can: flexcan: add ipg and ser clocks support Hui Wang
2012-06-27 8:19 ` [PATCH 4/4] can: flexcan: add transceiver switch support when use device tree Hui Wang
2012-06-27 8:26 ` Marc Kleine-Budde
2012-06-27 9:55 ` Hui Wang
2012-06-27 10:02 ` Marc Kleine-Budde
2012-06-27 11:22 ` Shawn Guo
2012-06-27 11:46 ` Marc Kleine-Budde
2012-06-28 1:53 ` Hui Wang
2012-06-27 8:45 ` Marc Kleine-Budde [this message]
2012-06-27 8:27 ` [PATCH 2/4] can: flexcan: add hardware controller version support Marc Kleine-Budde
2012-06-27 8:56 ` Wolfgang Grandegger
2012-06-27 9:43 ` Wolfgang Grandegger
2012-06-27 9:51 ` Marc Kleine-Budde
2012-06-27 10:13 ` Hui Wang
2012-06-27 10:24 ` Marc Kleine-Budde
2012-06-27 10:57 ` Wolfgang Grandegger
2012-06-27 8:38 ` [PATCH 1/4] can: flexcan: use be32_to_cpup to handle the value of dt entry Marc Kleine-Budde
2012-06-27 9:07 ` Wolfgang Grandegger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FEAC821.4070604@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=davem@davemloft.net \
--cc=jason77.wang@gmail.com \
--cc=linux-can@vger.kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.