All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: dedekind1@gmail.com
Cc: "Nikita V. Youshchenko" <nyoushchenko@mvista.com>,
	Alexander Kaliadin <akaliadin@mvista.com>,
	linux-mtd@lists.infradead.org, Rob Taylor <rtaylor@mvista.com>,
	Pavan Jadhav <pjadhav@mvista.com>
Subject: Re: ubi_update_fastmap: could not find an early PEB
Date: Wed, 27 Jun 2012 13:00:29 +0200	[thread overview]
Message-ID: <4FEAE7CD.6060803@nod.at> (raw)
In-Reply-To: <1340794586.29342.52.camel@sauron.fi.intel.com>

[-- Attachment #1: Type: text/plain, Size: 1263 bytes --]

Am 27.06.2012 12:56, schrieb Artem Bityutskiy:
> I've just pushed out the latest work of Richard to the "fastmap" branch,
> should be up-to-date now. Thanks for feed-back, testing is very
> appreciated and certainly should help merging this faster.
> 

I'll send another patch set today.
It contains only minor coding style fixes and such stuff.

Before fastmap gets merged I'd like to have a discussion about fastmaps
parameters.

/* A fastmap anchor block can be located between PEB 0 and
 * UBI_FM_MAX_START */
#define UBI_FM_MAX_START        64

/* A fastmap can use up to UBI_FM_MAX_BLOCKS PEBs */
#define UBI_FM_MAX_BLOCKS       32

/* 5% of the total number of PEBs have to be scanned while attaching
 * from a fastmap.
 * But the size of this pool is limited to be between UBI_FM_MIN_POOL_SIZE and
 * UBI_FM_MAX_POOL_SIZE */
#define UBI_FM_MIN_POOL_SIZE    8
#define UBI_FM_MAX_POOL_SIZE    256
#define UBI_FM_WL_POOL_SIZE     25

Are we all fine with them?
Especially the size of both pools used by fastmap needs to be discussed more.
If the pool size is too small UBI was to write the fastmap very often.
A too large pool means that attaching takes longer because fastmap has to rescan
more PEBs.

Thanks,
//richard


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]

  reply	other threads:[~2012-06-27 11:00 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-22 16:05 ubi_update_fastmap: could not find an early PEB Nikita V. Youshchenko
2012-06-22 16:32 ` Richard Weinberger
2012-06-22 17:26   ` Nikita V. Youshchenko
2012-06-22 17:37     ` Richard Weinberger
2012-06-22 18:46       ` Nikita V. Youshchenko
2012-06-22 18:49         ` Richard Weinberger
2012-06-27 10:56     ` Artem Bityutskiy
2012-06-27 11:00       ` Richard Weinberger [this message]
2012-06-27 11:07         ` Nikita V. Youshchenko
2012-06-27 12:15           ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FEAE7CD.6060803@nod.at \
    --to=richard@nod.at \
    --cc=akaliadin@mvista.com \
    --cc=dedekind1@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=nyoushchenko@mvista.com \
    --cc=pjadhav@mvista.com \
    --cc=rtaylor@mvista.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.