Re: #size-cells = <0> in a bus node, and kernel messages complaining about this

[Mitch Bradley <wmb-D5eQfiDGL7eakBO8gow8eQ@public.gmane.org>]

On 6/27/2012 11:26 AM, Stephen Warren wrote:
> I believe I've seen the following construct bandied about as the correct
> way of representing a bunch of nodes that have the same name (since they
> represent the same type of object) within device-tree.
>
> 	regulators {
> 		compatible = "simple-bus";
> 		#address-cells = <1>;
> 		#size-cells = <0>;
>
> 		regulator@0 {
> 			compatible = "regulator-fixed";
> 			reg = <0>;
> ...
> 		};
>
> 		regulator@1 {
> 			compatible = "regulator-fixed";
> 			reg = <1>;
> ...
> 		};
> 	};
>
> However, when the kernel parses that, it issues messages such as:
>
> prom_parse: Bad cell count for /regulators/regulator@0
> prom_parse: Bad cell count for /regulators/regulator@1

The message comes from __of_translate_address(), which has the comment:

  * Note: We consider that crossing any level with #size-cells == 0 to mean
  * that translation is impossible (that is we are not dealing with a value
  * that can be mapped to a cpu physical address). This is not really specified
  * that way, but this is traditionally the way IBM at least do things

So it seems that the problem only occurs if something tries to translate
the regulator's "reg" address to a CPU address.  Is that possible/meaningful
in your case?

I ran into a problem like this recently.  If I recall correctly, the root cause 
was that some code that I "inherited" was using of_address_to_resource() to 
process a "reg" property in a case where the "reg" was not memory-mappable.
I changed the code to use "of_get_address()" instead.

of_address_to_resource() calls of_get_address(), and then proceeds to convert 
the bus-relative address to a CPU address.

>
> The message is issued when #size-cells==0. Is the response simply "don't
> do that", and so I should set #size-cells=1, and add a fake size cell in
> the reg property too?
>
> Given the number of hits on '#size-cells = <0>' in the kernel source
> tree, it seems like I must be missing something here; it's quite widely
> used. I guess the warning is probably only emitted when the node with
> #size-cells=0 is a bus, and so the children are enumerated to
> instantiated devices; perhaps that's why this hasn't been raised before?
> _______________________________________________
> devicetree-discuss mailing list
> devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
> https://lists.ozlabs.org/listinfo/devicetree-discuss
>