From: "Yan, Zheng" <zheng.z.yan@intel.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: eranian@google.com, mingo@elte.hu, andi@firstfloor.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] perf/x86: Uncore Filter support for SandyBridge-EP
Date: Thu, 28 Jun 2012 09:30:17 +0800 [thread overview]
Message-ID: <4FEBB3A9.6090906@intel.com> (raw)
In-Reply-To: <1340791604.10063.10.camel@twins>
On 06/27/2012 06:06 PM, Peter Zijlstra wrote:
> On Wed, 2012-06-27 at 15:09 +0800, Yan, Zheng wrote:
>> > @@ -1048,10 +1190,9 @@ static int uncore_validate_group(struct intel_uncore_pmu *pmu,
>> > {
>> > struct perf_event *leader = event->group_leader;
>> > struct intel_uncore_box *fake_box;
>> > - int assign[UNCORE_PMC_IDX_MAX];
>> > int ret = -EINVAL, n;
>> >
>> > - fake_box = uncore_alloc_box(smp_processor_id());
>> > + fake_box = uncore_alloc_box(pmu->type, smp_processor_id());
>> > if (!fake_box)
>> > return -ENOMEM;
>> >
>> > @@ -1073,7 +1214,7 @@ static int uncore_validate_group(struct intel_uncore_pmu *pmu,
>> >
>> > fake_box->n_events = n;
>> >
>> > - ret = uncore_assign_events(fake_box, assign, n);
>> > + ret = uncore_assign_events(fake_box, NULL, n);
>> > out:
>> > kfree(fake_box);
>> > return ret;
> Isn't the uncore now suffering the same problem you found for the
> regular extra stuff?
The snbep_uncore_get/put_constraint(...) has check for that. The uncore case is simpler,
because we don't need try swapping RSP_0/RSP_1.
Regards
Yan, Zheng
next prev parent reply other threads:[~2012-06-28 1:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-27 7:09 [PATCH 1/2] perf/x86: Use 0xff as pseudo code for fixed uncore event Yan, Zheng
2012-06-27 7:09 ` [PATCH 2/2] perf/x86: Uncore Filter support for SandyBridge-EP Yan, Zheng
2012-06-27 9:42 ` Peter Zijlstra
2012-06-27 10:01 ` Peter Zijlstra
2012-06-27 10:06 ` Peter Zijlstra
2012-06-28 1:30 ` Yan, Zheng [this message]
2012-06-28 10:10 ` Peter Zijlstra
2012-06-27 13:06 ` [PATCH 1/2] perf/x86: Use 0xff as pseudo code for fixed uncore event Stephane Eranian
2012-06-27 13:10 ` Peter Zijlstra
2012-07-06 6:30 ` [tip:perf/core] " tip-bot for Yan, Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FEBB3A9.6090906@intel.com \
--to=zheng.z.yan@intel.com \
--cc=a.p.zijlstra@chello.nl \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.