Re: [PATCH v2 1/2] can: flexcan: use of_property_read_u32 to get DT entry value

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 1769 bytes --]

On 06/28/2012 10:21 AM, Hui Wang wrote:
> of_property_read_u32() can auto handle endian problems, use this
> function can make code clean and simple.
> 
> No need to check return value here since the following got value
> check will handle this.

Should this go to v3.5 or to net-next? If it goes via net-next, I have
to delay it until David merges net (which has the be32_to_cpup fix).

Marc

> 
> Cc: linux-can@vger.kernel.org
> Cc: Marc Kleine-Budde <mkl@pengutronix.de>
> Cc: Wolfgang Grandegger <wg@grandegger.com>
> Cc: Shawn Guo <shawn.guo@linaro.org>
> Signed-off-by: Hui Wang <jason77.wang@gmail.com>
> ---
>  drivers/net/can/flexcan.c |   11 +++--------
>  1 files changed, 3 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c
> index 81d4741..f63f826 100644
> --- a/drivers/net/can/flexcan.c
> +++ b/drivers/net/can/flexcan.c
> @@ -938,14 +938,9 @@ static int __devinit flexcan_probe(struct platform_device *pdev)
>  	if (IS_ERR(pinctrl))
>  		return PTR_ERR(pinctrl);
>  
> -	if (pdev->dev.of_node) {
> -		const __be32 *clock_freq_p;
> -
> -		clock_freq_p = of_get_property(pdev->dev.of_node,
> -						"clock-frequency", NULL);
> -		if (clock_freq_p)
> -			clock_freq = be32_to_cpup(clock_freq_p);
> -	}
> +	if (pdev->dev.of_node)
> +		of_property_read_u32(pdev->dev.of_node,
> +						"clock-frequency", &clock_freq);
>  
>  	if (!clock_freq) {
>  		clk = clk_get(&pdev->dev, NULL);


-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]