From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com ([143.182.124.21]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1SkIfO-0002TX-Ql for openembedded-core@lists.openembedded.org; Thu, 28 Jun 2012 19:38:07 +0200 Received: from azsmga001.ch.intel.com ([10.2.17.19]) by azsmga101.ch.intel.com with ESMTP; 28 Jun 2012 10:27:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.71,315,1320652800"; d="scan'208";a="161874782" Received: from unknown (HELO [10.255.12.182]) ([10.255.12.182]) by azsmga001.ch.intel.com with ESMTP; 28 Jun 2012 10:27:10 -0700 Message-ID: <4FEC93ED.2040102@linux.intel.com> Date: Thu, 28 Jun 2012 10:27:09 -0700 From: Saul Wold User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Patches and discussions about the oe-core layer References: <1340859395-13638-1-git-send-email-dennis.lan@actions-semi.com> In-Reply-To: <1340859395-13638-1-git-send-email-dennis.lan@actions-semi.com> Subject: Re: [PATCH v2] openjade-native: fix undefined Getopts error, use std namespace X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Patches and discussions about the oe-core layer List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jun 2012 17:38:07 -0000 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 06/27/2012 09:56 PM, dennis lan wrote: > From: Dennis Lan > > Using Gentoo Linux as the build host, it fails without this patch > Use Getopt::Std in place of getopts.pl. > > https://bugs.gentoo.org/show_bug.cgi?id=420083 > > which following error: > /usr/bin/perl -w ./../msggen.pl -l jstyleModule InterpreterMessages.msg > /usr/bin/perl -w ./../msggen.pl -l jstyleModule DssslAppMessages.msg > Undefined subroutine&main::Getopts called at ./../msggen.pl line 22. > make[2]: *** [InterpreterMessages.h] Error 2 > make[2]: *** Waiting for unfinished jobs.... > Undefined subroutine&main::Getopts called at ./../msggen.pl line 22. > make[2]: *** [DssslAppMessages.h] Error 2 > > Upstream-Status: Submitted [openjade-devel@lists.sourceforge.net] > This needs to be in the patch file itself, we can track the patches better that way. > Signed-off-by: Dennis Lan > --- > .../openjade/openjade-1.3.2/msggen.pl.patch | 32 ++++++++++++++++++++ > .../openjade/openjade-native_1.3.2.bb | 1 + > 2 files changed, 33 insertions(+), 0 deletions(-) > create mode 100644 meta/recipes-devtools/openjade/openjade-1.3.2/msggen.pl.patch > > diff --git a/meta/recipes-devtools/openjade/openjade-1.3.2/msggen.pl.patch b/meta/recipes-devtools/openjade/openjade-1.3.2/msggen.pl.patch > new file mode 100644 > index 0000000..1afe68b > --- /dev/null > +++ b/meta/recipes-devtools/openjade/openjade-1.3.2/msggen.pl.patch Please add comment Upstream-Status and SOB to the patch itself. Thanks Sau! > @@ -0,0 +1,32 @@ > +Use Getopt::Std in place of getopts.pl. > +https://bugs.gentoo.org/show_bug.cgi?id=420083 > + > +--- a/msggen.pl > ++++ b/msggen.pl > +@@ -4,6 +4,7 @@ > + # See the file COPYING for copying permission. > + > + use POSIX; > ++use Getopt::Std; > + > + # Package and version. > + $package = 'openjade'; > +@@ -18,8 +19,7 @@ > + undef $opt_l; > + undef $opt_p; > + undef $opt_t; > +-do 'getopts.pl'; > +-&Getopts('l:p:t:'); > ++getopts('l:p:t:'); > + $module = $opt_l; > + $pot_file = $opt_p; > + > +@@ -72,7 +72,7 @@ > + else { > + $field[0] =~ /^[IWQXE][0-9]$/ ||&error("invalid first field");; > + $type[$num] = substr($field[0], 0, 1); > +- $argc = int(substr($field[0], 1, 1)); > ++ $argc = substr($field[0], 1, 1); > + } > + $nargs[$num] = $argc; > + $field[1] =~ /^[a-zA-Z_][a-zA-Z0-9_]+$/ ||&error("invalid tag"); > diff --git a/meta/recipes-devtools/openjade/openjade-native_1.3.2.bb b/meta/recipes-devtools/openjade/openjade-native_1.3.2.bb > index 5b29c1f..efd1e11 100644 > --- a/meta/recipes-devtools/openjade/openjade-native_1.3.2.bb > +++ b/meta/recipes-devtools/openjade/openjade-native_1.3.2.bb > @@ -14,6 +14,7 @@ RDEPENDS_${PN} = "sgml-common-native" > > SRC_URI = "${SOURCEFORGE_MIRROR}/openjade/openjade-${PV}.tar.gz \ > file://makefile.patch \ > + file://msggen.pl.patch \ > file://reautoconf.patch \ > file://user-declared-default-constructor.patch" >