From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752092Ab2F2I0I (ORCPT ); Fri, 29 Jun 2012 04:26:08 -0400 Received: from fgwmail5.fujitsu.co.jp ([192.51.44.35]:55749 "EHLO fgwmail5.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750866Ab2F2I0B (ORCPT ); Fri, 29 Jun 2012 04:26:01 -0400 X-SecurityPolicyCheck: OK by SHieldMailChecker v1.7.4 Message-ID: <4FED6604.9080603@jp.fujitsu.com> Date: Fri, 29 Jun 2012 17:23:32 +0900 From: Kamezawa Hiroyuki User-Agent: Mozilla/5.0 (Windows NT 6.0; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: Sha Zhengju CC: linux-mm@kvack.org, cgroups@vger.kernel.org, gthelen@google.com, yinghan@google.com, akpm@linux-foundation.org, mhocko@suse.cz, linux-kernel@vger.kernel.org, Sha Zhengju Subject: Re: [PATCH 0/7] Per-cgroup page stat accounting References: <1340880885-5427-1-git-send-email-handai.szj@taobao.com> In-Reply-To: <1340880885-5427-1-git-send-email-handai.szj@taobao.com> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (2012/06/28 19:54), Sha Zhengju wrote: > This patch series provide the ability for each memory cgroup to have independent > dirty/writeback page stats. This can provide some information for per-cgroup direct > reclaim. Meanwhile, we add more detailed dump messages for memcg OOMs. > > Three features are included in this patch series: > (0).prepare patches for page accounting > 1. memcg dirty page accounting > 2. memcg writeback page accounting > 3. memcg OOMs dump info > > In (0) prepare patches, we have reworked vfs set page dirty routines to make "modify > page info" and "dirty page accouting" stay in one function as much as possible for > the sake of memcg bigger lock. > > These patches are cooked based on Andrew's akpm tree. > Thank you !, it seems good in general. I'll review in detail, later. Do you have any performance comparison between before/after the series ? I mean, set_page_dirty() is the hot-path and we should be careful to add a new accounting. Thanks, -Kame > Sha Zhengju (7): > memcg-update-cgroup-memory-document.patch > memcg-remove-MEMCG_NR_FILE_MAPPED.patch > Make-TestSetPageDirty-and-dirty-page-accounting-in-o.patch > Use-vfs-__set_page_dirty-interface-instead-of-doing-.patch > memcg-add-per-cgroup-dirty-pages-accounting.patch > memcg-add-per-cgroup-writeback-pages-accounting.patch > memcg-print-more-detailed-info-while-memcg-oom-happe.patch > > Documentation/cgroups/memory.txt | 2 + > fs/buffer.c | 36 +++++++++----- > fs/ceph/addr.c | 20 +------- > include/linux/buffer_head.h | 2 + > include/linux/memcontrol.h | 27 +++++++--- > mm/filemap.c | 5 ++ > mm/memcontrol.c | 99 +++++++++++++++++++++++-------------- > mm/page-writeback.c | 42 ++++++++++++++-- > mm/rmap.c | 4 +- > mm/truncate.c | 6 ++ > 10 files changed, 159 insertions(+), 84 deletions(-) > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kamezawa Hiroyuki Subject: Re: [PATCH 0/7] Per-cgroup page stat accounting Date: Fri, 29 Jun 2012 17:23:32 +0900 Message-ID: <4FED6604.9080603@jp.fujitsu.com> References: <1340880885-5427-1-git-send-email-handai.szj@taobao.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1340880885-5427-1-git-send-email-handai.szj@taobao.com> Sender: owner-linux-mm@kvack.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Sha Zhengju Cc: linux-mm@kvack.org, cgroups@vger.kernel.org, gthelen@google.com, yinghan@google.com, akpm@linux-foundation.org, mhocko@suse.cz, linux-kernel@vger.kernel.org, Sha Zhengju (2012/06/28 19:54), Sha Zhengju wrote: > This patch series provide the ability for each memory cgroup to have independent > dirty/writeback page stats. This can provide some information for per-cgroup direct > reclaim. Meanwhile, we add more detailed dump messages for memcg OOMs. > > Three features are included in this patch series: > (0).prepare patches for page accounting > 1. memcg dirty page accounting > 2. memcg writeback page accounting > 3. memcg OOMs dump info > > In (0) prepare patches, we have reworked vfs set page dirty routines to make "modify > page info" and "dirty page accouting" stay in one function as much as possible for > the sake of memcg bigger lock. > > These patches are cooked based on Andrew's akpm tree. > Thank you !, it seems good in general. I'll review in detail, later. Do you have any performance comparison between before/after the series ? I mean, set_page_dirty() is the hot-path and we should be careful to add a new accounting. Thanks, -Kame > Sha Zhengju (7): > memcg-update-cgroup-memory-document.patch > memcg-remove-MEMCG_NR_FILE_MAPPED.patch > Make-TestSetPageDirty-and-dirty-page-accounting-in-o.patch > Use-vfs-__set_page_dirty-interface-instead-of-doing-.patch > memcg-add-per-cgroup-dirty-pages-accounting.patch > memcg-add-per-cgroup-writeback-pages-accounting.patch > memcg-print-more-detailed-info-while-memcg-oom-happe.patch > > Documentation/cgroups/memory.txt | 2 + > fs/buffer.c | 36 +++++++++----- > fs/ceph/addr.c | 20 +------- > include/linux/buffer_head.h | 2 + > include/linux/memcontrol.h | 27 +++++++--- > mm/filemap.c | 5 ++ > mm/memcontrol.c | 99 +++++++++++++++++++++++-------------- > mm/page-writeback.c | 42 ++++++++++++++-- > mm/rmap.c | 4 +- > mm/truncate.c | 6 ++ > 10 files changed, 159 insertions(+), 84 deletions(-) > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org