All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: tiwai@suse.de, perex@perex.cz, swarren@nvidia.com,
	broonie@opensource.wolfsonmicro.com, lrg@ti.com,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	linux-tegra@vger.kernel.org
Subject: Re: [PATCH] ASoC: tegra: use dmaengine based dma driver
Date: Fri, 29 Jun 2012 11:02:01 -0600	[thread overview]
Message-ID: <4FEDDF89.1050907@wwwdotorg.org> (raw)
In-Reply-To: <1340969673-7776-2-git-send-email-ldewangan@nvidia.com>

On 06/29/2012 05:34 AM, Laxman Dewangan wrote:
> Use the dmaengine based Tegra APB DMA driver for
> data transfer between SPI fifo and memory in
> place of legacy Tegra APB DMA.
> 
> Because generic soc-dmaengine-pcm uses the DMAs API
> based on dmaengine, using the exported APIs provided
> by this generic driver.
> 
> The new driver is selected if legacy driver is not
> selected and new dma driver is enabled through config
> file.

This works just fine with the existing non-dmaengine DMA driver enabled.

However, I can't get it to work with dmaengine:

> # aplay ~/abba-dq-48000-stereo.wav
> [  151.613476] tegra20-i2s tegra20-i2s.0: dmaengine pcm open failed with err -6
> [  151.620557] tegra20-i2s tegra20-i2s.0: can't open platform tegra20-i2s.0: -6
> aplay: main:654: audio open error: No such device or address

I do have the following in my local tree:
68a67b8 ARM: tegra: add device tree AUXDATA for APBDMA
0db7a96 ARM: tegra: dma: rename driver name for clock to "tegra-apbdma"

I also fixed the compatible values in drivers/dma/tegra20-apb-dma.c so
the driver would get instantiated, which it does;
/sys/devices/tegra-apbdma/dma has a bunch of dmaengine channels in it.

(Note: This is on Ventana, although I doubt that makes much difference)

Is there something else I need to do to test this?

  reply	other threads:[~2012-06-29 17:02 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-29 11:34 [PATCH] ARM: tegra: apbio: use dmaengine based dma driver Laxman Dewangan
2012-06-29 11:34 ` Laxman Dewangan
     [not found] ` <1340969673-7776-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-06-29 11:34   ` [PATCH] ASoC: tegra: " Laxman Dewangan
2012-06-29 11:34     ` Laxman Dewangan
2012-06-29 17:02     ` Stephen Warren [this message]
     [not found]       ` <4FEDDF89.1050907-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-06-30 15:08         ` Laxman Dewangan
2012-06-30 15:08           ` Laxman Dewangan
     [not found]           ` <4FEF166D.2010705-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-07-02  8:25             ` Laxman Dewangan
2012-07-02  8:25               ` Laxman Dewangan
     [not found]               ` <4FF15B16.9020903-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-07-02 16:45                 ` Stephen Warren
2012-07-02 16:45                   ` Stephen Warren
2012-07-02 16:47                   ` Mark Brown
2012-07-02 16:47                     ` Mark Brown
2012-07-03  6:26                     ` Laxman Dewangan
     [not found]                     ` <20120702164717.GH25093-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-07-18  8:59                       ` Laxman Dewangan
2012-07-18  8:59                         ` Laxman Dewangan
     [not found]     ` <1340969673-7776-2-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-07-02 16:46       ` Stephen Warren
2012-07-02 16:46         ` Stephen Warren
     [not found]         ` <4FF1D083.7060207-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-07-03  6:29           ` Laxman Dewangan
2012-07-03  6:29             ` Laxman Dewangan
2012-07-03 10:09             ` Mark Brown
2012-07-03 19:07       ` Mark Brown
2012-07-03 19:07         ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FEDDF89.1050907@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=ldewangan@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=lrg@ti.com \
    --cc=perex@perex.cz \
    --cc=swarren@nvidia.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.