From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:58365)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <owasserm@redhat.com>) id 1SlGe2-0008SI-U8
	for qemu-devel@nongnu.org; Sun, 01 Jul 2012 05:40:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <owasserm@redhat.com>) id 1SlGe1-0007NJ-2K
	for qemu-devel@nongnu.org; Sun, 01 Jul 2012 05:40:42 -0400
Received: from mx1.redhat.com ([209.132.183.28]:63250)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <owasserm@redhat.com>) id 1SlGe0-0007NE-RA
	for qemu-devel@nongnu.org; Sun, 01 Jul 2012 05:40:41 -0400
Received: from int-mx12.intmail.prod.int.phx2.redhat.com
	(int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q619ee3v023148
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Sun, 1 Jul 2012 05:40:40 -0400
Message-ID: <4FF01B25.7050407@redhat.com>
Date: Sun, 01 Jul 2012 12:40:53 +0300
From: Orit Wasserman <owasserm@redhat.com>
MIME-Version: 1.0
References: <cover.1340910651.git.quintela@redhat.com>
	<509b501d09f18212b4165ee116ddef4ceba59097.1340910651.git.quintela@redhat.com>
In-Reply-To: <509b501d09f18212b4165ee116ddef4ceba59097.1340910651.git.quintela@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 04/12] savevm: remove SaveLiveStateHandler
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org

On 06/28/2012 10:22 PM, Juan Quintela wrote:
> It was used only once, just unfold.
> 
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
>  vmstate.h |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/vmstate.h b/vmstate.h
> index 5e1a7cc..0e24834 100644
> --- a/vmstate.h
> +++ b/vmstate.h
> @@ -27,13 +27,12 @@
>  #define QEMU_VMSTATE_H 1
> 
>  typedef void SaveStateHandler(QEMUFile *f, void *opaque);
> -typedef int SaveLiveStateHandler(QEMUFile *f, int stage, void *opaque);
>  typedef int LoadStateHandler(QEMUFile *f, void *opaque, int version_id);
> 
>  typedef struct SaveVMHandlers {
>      void (*set_params)(const MigrationParams *params, void * opaque);
>      SaveStateHandler *save_state;
> -    SaveLiveStateHandler *save_live_state;
> +    int (*save_live_state)(QEMUFile *f, int stage, void *opaque);
>      LoadStateHandler *load_state;
>  } SaveVMHandlers;
> 
Reviewed-by: Orit Wasserman <owasserm@redhat.com>