From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37878) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SlIGj-0008Rp-FB for qemu-devel@nongnu.org; Sun, 01 Jul 2012 07:24:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SlIGh-0007AL-Mx for qemu-devel@nongnu.org; Sun, 01 Jul 2012 07:24:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36236) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SlIGh-0007A7-Er for qemu-devel@nongnu.org; Sun, 01 Jul 2012 07:24:43 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q61BOgNE023916 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 1 Jul 2012 07:24:42 -0400 Message-ID: <4FF03387.5010702@redhat.com> Date: Sun, 01 Jul 2012 14:24:55 +0300 From: Orit Wasserman MIME-Version: 1.0 References: <620debbcb9bc99dc6db54d87a8683efbc00c2b66.1340910651.git.quintela@redhat.com> <4FF00826.3080006@redhat.com> <87obnzu6ji.fsf@elfo.mitica> In-Reply-To: <87obnzu6ji.fsf@elfo.mitica> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 02/12] savevm: Live migration handlers register the struct directly List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: quintela@redhat.com Cc: qemu-devel@nongnu.org On 07/01/2012 01:20 PM, Juan Quintela wrote: > Orit Wasserman wrote: >> On 06/28/2012 10:22 PM, Juan Quintela wrote: >>> Notice that the live migration users never unregister, so no problem >>> about freeing the ops structure. >>> void unregister_savevm(DeviceState *dev, const char *idstr, void *opaque) >>> diff --git a/vl.c b/vl.c >>> index 1329c30..b1f31e8 100644 >>> --- a/vl.c >>> +++ b/vl.c >>> @@ -3438,8 +3438,7 @@ int main(int argc, char **argv, char **envp) >>> default_drive(default_sdcard, snapshot, machine->use_scsi, >>> IF_SD, 0, SD_OPTS); >>> >>> - register_savevm_live(NULL, "ram", 0, 4, NULL, ram_save_live, NULL, >>> - ram_load, NULL); >>> + register_savevm_live(NULL, "ram", 0, 4, &savevm_ram_handlers, NULL); >>> >> >> Juan, >> Can't we move it migration.c (migrate_init and qemu_start_incoming migration)? >> this will remove to use an extern for savevm_ram_handlers. > > savevm_ram_handlers are exported from arch_init.c, what do we win if we > move it? Furthermore, I add more functions to this extructure later in > the series, so not exporting the structure and having to export more > functions what bring to us? well it shouldn't be in vl.c , there is no reason (correct me if I'm wrong) to register "ram" handlers if there is no migration ... Orit > > Thanks, Juan. >