All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	mst@redhat.com, David Gibson <david@gibson.dropbear.id.au>
Subject: [Qemu-devel] [PATCH] eventfd: making it rhread safe
Date: Mon, 02 Jul 2012 05:48:16 +1000	[thread overview]
Message-ID: <4FF0A980.4070903@ozlabs.ru> (raw)
In-Reply-To: <4FF066AF.40606@redhat.com>

QEMU uses IO handlers to run select() in the main loop. The handlers list is managed by qemu_set_fd_handler() helper which works fine when called from the main thread as it is called not when select() is waiting.

However sometime we need to update the handlers list from another thread. For that the main loop's select() needs to be restarted with the updated list.

The patch adds the qemu_notify_event() call to interrupt select() and make wrapping code to restart select() with the updated IO handlers list.

Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

---
 iohandler.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/iohandler.c b/iohandler.c
index 3c74de6..dea4355 100644
--- a/iohandler.c
+++ b/iohandler.c
@@ -77,6 +77,7 @@ int qemu_set_fd_handler2(int fd,
         ioh->fd_write = fd_write;
         ioh->opaque = opaque;
         ioh->deleted = 0;
+        qemu_notify_event();
     }
     return 0;
 }
-- 
1.7.10

  reply	other threads:[~2012-07-01 19:48 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-01 11:06 [Qemu-devel] QEMU question: is eventfd not thread safe? Alexey Kardashevskiy
2012-07-01 12:43 ` Michael S. Tsirkin
2012-07-01 12:57   ` Alexey Kardashevskiy
2012-07-01 23:07     ` Benjamin Herrenschmidt
2012-07-02  0:06       ` Alexey Kardashevskiy
2012-07-02  0:42         ` ronnie sahlberg
2012-07-02  0:45           ` Benjamin Herrenschmidt
2012-07-02  0:44         ` Benjamin Herrenschmidt
2012-07-02  0:49         ` Benjamin Herrenschmidt
2012-07-01 22:30   ` Benjamin Herrenschmidt
2012-07-01 13:32 ` Paolo Bonzini
2012-07-01 13:40   ` Alexey Kardashevskiy
2012-07-01 14:46     ` Alexey Kardashevskiy
2012-07-01 15:03       ` Paolo Bonzini
2012-07-01 19:48         ` Alexey Kardashevskiy [this message]
2012-07-09  3:10           ` [Qemu-devel] [PATCH] eventfd: making it rhread safe Alexey Kardashevskiy
2012-07-18  8:25             ` Alexey Kardashevskiy
2012-07-18 11:47           ` Michael S. Tsirkin
2012-07-18 12:08           ` [Qemu-devel] [PATCH] eventfd: making it thread safe Alexey Kardashevskiy
2012-07-18 12:22             ` Michael S. Tsirkin
2012-07-18 12:58               ` Alexey Kardashevskiy
2012-07-18 12:52             ` Alexey Kardashevskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FF0A980.4070903@ozlabs.ru \
    --to=aik@ozlabs.ru \
    --cc=alex.williamson@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.