From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Sascha Hauer <sha@pengutronix.de>
Cc: linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de,
linux-can@vger.kernel.org
Subject: Re: [PATCH 1/2] arm: imx: enable flexcan on imx25, imx35, imx53, imx6q
Date: Mon, 02 Jul 2012 09:54:08 +0200 [thread overview]
Message-ID: <4FF153A0.3030404@pengutronix.de> (raw)
In-Reply-To: <20120702075054.GF2698@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 1210 bytes --]
On 07/02/2012 09:50 AM, Sascha Hauer wrote:
> On Sun, Jul 01, 2012 at 10:46:04PM +0200, Marc Kleine-Budde wrote:
>> Cc: Sascha Hauer <sha@pengutronix.de>
>> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
>> ---
>> arch/arm/mach-imx/Kconfig | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
>> index eff4db5..c296851 100644
>> --- a/arch/arm/mach-imx/Kconfig
>> +++ b/arch/arm/mach-imx/Kconfig
>> @@ -52,6 +52,7 @@ config SOC_IMX25
>> select ARCH_MX25
>> select COMMON_CLK
>> select CPU_ARM926T
>> + select HAVE_CAN_FLEXCAN if CAN
>
> Do we need the 'if CAN' here? It seems yes, since HAVE_CAN_FLEXCAN is
> inside the "CAN Device Drivers" menu which depends on CAN. Shouldn't the
> HAVE_CAN_FLECAN be outside the menu?
Yes, we can move the HAVE_CAN_FLEXCAN outside of that menu, but it still
depends on CONFIG_NET.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: mkl@pengutronix.de (Marc Kleine-Budde)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] arm: imx: enable flexcan on imx25, imx35, imx53, imx6q
Date: Mon, 02 Jul 2012 09:54:08 +0200 [thread overview]
Message-ID: <4FF153A0.3030404@pengutronix.de> (raw)
In-Reply-To: <20120702075054.GF2698@pengutronix.de>
On 07/02/2012 09:50 AM, Sascha Hauer wrote:
> On Sun, Jul 01, 2012 at 10:46:04PM +0200, Marc Kleine-Budde wrote:
>> Cc: Sascha Hauer <sha@pengutronix.de>
>> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
>> ---
>> arch/arm/mach-imx/Kconfig | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
>> index eff4db5..c296851 100644
>> --- a/arch/arm/mach-imx/Kconfig
>> +++ b/arch/arm/mach-imx/Kconfig
>> @@ -52,6 +52,7 @@ config SOC_IMX25
>> select ARCH_MX25
>> select COMMON_CLK
>> select CPU_ARM926T
>> + select HAVE_CAN_FLEXCAN if CAN
>
> Do we need the 'if CAN' here? It seems yes, since HAVE_CAN_FLEXCAN is
> inside the "CAN Device Drivers" menu which depends on CAN. Shouldn't the
> HAVE_CAN_FLECAN be outside the menu?
Yes, we can move the HAVE_CAN_FLEXCAN outside of that menu, but it still
depends on CONFIG_NET.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 262 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120702/ae72385b/attachment.sig>
next prev parent reply other threads:[~2012-07-02 7:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-01 20:46 [PATCH 0/2] arm: imx/mxs: enable flexcan driver Marc Kleine-Budde
2012-07-01 20:46 ` Marc Kleine-Budde
2012-07-01 20:46 ` [PATCH 1/2] arm: imx: enable flexcan on imx25, imx35, imx53, imx6q Marc Kleine-Budde
2012-07-01 20:46 ` Marc Kleine-Budde
2012-07-02 7:50 ` Sascha Hauer
2012-07-02 7:50 ` Sascha Hauer
2012-07-02 7:54 ` Marc Kleine-Budde [this message]
2012-07-02 7:54 ` Marc Kleine-Budde
2012-07-02 8:06 ` Sascha Hauer
2012-07-02 8:06 ` Sascha Hauer
2012-07-01 20:46 ` [PATCH 2/2] arm: mxs: enable flexcan on imx28 Marc Kleine-Budde
2012-07-01 20:46 ` Marc Kleine-Budde
2012-07-02 2:01 ` Shawn Guo
2012-07-02 2:01 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF153A0.3030404@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=sha@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.