On 07/02/2012 09:50 AM, Sascha Hauer wrote: > On Sun, Jul 01, 2012 at 10:46:04PM +0200, Marc Kleine-Budde wrote: >> Cc: Sascha Hauer >> Signed-off-by: Marc Kleine-Budde >> --- >> arch/arm/mach-imx/Kconfig | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig >> index eff4db5..c296851 100644 >> --- a/arch/arm/mach-imx/Kconfig >> +++ b/arch/arm/mach-imx/Kconfig >> @@ -52,6 +52,7 @@ config SOC_IMX25 >> select ARCH_MX25 >> select COMMON_CLK >> select CPU_ARM926T >> + select HAVE_CAN_FLEXCAN if CAN > > Do we need the 'if CAN' here? It seems yes, since HAVE_CAN_FLEXCAN is > inside the "CAN Device Drivers" menu which depends on CAN. Shouldn't the > HAVE_CAN_FLECAN be outside the menu? Yes, we can move the HAVE_CAN_FLEXCAN outside of that menu, but it still depends on CONFIG_NET. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |