From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Hui Wang <jason77.wang@gmail.com>
Cc: linux-can@vger.kernel.org, kernel@pengutronix.de,
Wolfgang Grandegger <wg@grandegger.com>,
Shawn Guo <shawn.guo@linaro.org>
Subject: Re: [PATCH] can: flexcan: add hardware controller version support
Date: Mon, 02 Jul 2012 14:42:38 +0200 [thread overview]
Message-ID: <4FF1973E.4070005@pengutronix.de> (raw)
In-Reply-To: <4FF10668.4000504@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1705 bytes --]
On 07/02/2012 04:24 AM, Hui Wang wrote:
> Marc Kleine-Budde wrote:
>> From: Hui Wang <jason77.wang@gmail.com>
>>
>> At least in the i.MX series, the flexcan contrller divides into ver_3
>> and ver_10, current driver is for ver_3 controller.
>>
>> i.MX6 has ver_10 controller, it has more reigsters than ver_3 has.
>> The rxfgmask (Rx FIFO Global Mask) register is one of the new added.
>> Its reset value is 0xffffffff, this means ID Filter Table must be
>> checked when receive a packet, but the driver is designed to accept
>> everything during the chip start, we need to clear this register to
>> follow this design.
>>
>> Use the data entry of the struct of_device_id to point chip specific
>> info, we can set hardware version for each platform.
>>
>> Cc: linux-can@vger.kernel.org
>> Cc: Marc Kleine-Budde <mkl@pengutronix.de>
>> Cc: Wolfgang Grandegger <wg@grandegger.com>
>> Cc: Shawn Guo <shawn.guo@linaro.org>
>> Signed-off-by: Hui Wang <jason77.wang@gmail.com>
>> [mkl: add id_table support]
>> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
>> ---
>> Hui Wang,
>>
>> can you please test if this works for you on mx6.
>>
> Sorry for reply late.
>
> This patch works well on the mx6. But i found a minor problem, please
> see below.
I've fixed the issue in the patch series I just send (forgot to mention
that in the patch). Can I add your Acked-by and Tested-by?
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
next prev parent reply other threads:[~2012-07-02 12:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-01 20:21 [PATCH] can: flexcan: add hardware controller version support Marc Kleine-Budde
2012-07-02 2:24 ` Hui Wang
2012-07-02 7:23 ` Marc Kleine-Budde
2012-07-02 12:42 ` Marc Kleine-Budde [this message]
2012-07-03 3:07 ` Hui Wang
2012-07-18 9:50 ` Marc Kleine-Budde
2012-07-18 10:03 ` Hui Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF1973E.4070005@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=jason77.wang@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=shawn.guo@linaro.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.