From: Jonathan Cameron <jic23@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH 1/2] iio:kfifo_buf Take advantage of the fixed record size used in IIO
Date: Mon, 02 Jul 2012 15:50:00 +0100 [thread overview]
Message-ID: <4FF1B518.5080209@kernel.org> (raw)
In-Reply-To: <4FF18C68.5000904@metafoo.de>
On 7/2/2012 12:56 PM, Lars-Peter Clausen wrote:
> On 06/30/2012 02:52 PM, Jonathan Cameron wrote:
>> @@ -106,11 +108,12 @@ static int iio_read_first_n_kfifo(struct iio_buffer *r,
>> int ret, copied;
>> struct iio_kfifo *kf = iio_to_kfifo(r);
>>
>> - if (n < r->bytes_per_datum)
>> + if (n < r->bytes_per_datum || r->bytes_per_datum == 0)
>> return -EINVAL;
> Strictly speaking this is a unrelated change, but well...
Fair point. Naughty me ;( Will split out as a separate patch on next
version.
>
> I'll apply the kfifo patches to my IIO working tree and see if I'll get any
> issues.
Thanks
next prev parent reply other threads:[~2012-07-02 14:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-30 12:52 [PATCH 0/2] IIO: Kfifo usage improvements Jonathan Cameron
2012-06-30 12:52 ` [PATCH 1/2] iio:kfifo_buf Take advantage of the fixed record size used in IIO Jonathan Cameron
2012-07-02 11:56 ` Lars-Peter Clausen
2012-07-02 14:50 ` Jonathan Cameron [this message]
2012-06-30 12:52 ` [PATCH 2/2] iio: kfifo - add poll support Jonathan Cameron
2012-08-24 21:42 ` Marek Vasut
2012-08-25 8:24 ` Jonathan Cameron
2012-08-25 12:23 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF1B518.5080209@kernel.org \
--to=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.