From: Gerd Hoffmann <kraxel@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Erik Rull <erik.rull@rdsoftware.de>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] usb_packet_complete: Assertion ... failed
Date: Mon, 02 Jul 2012 17:47:35 +0200 [thread overview]
Message-ID: <4FF1C297.4030102@redhat.com> (raw)
In-Reply-To: <4FF1AF8C.5030400@siemens.com>
> diff --git a/hw/usb/core.c b/hw/usb/core.c
> index 0e02da7..eacda74 100644
> --- a/hw/usb/core.c
> +++ b/hw/usb/core.c
> @@ -407,7 +407,9 @@ void usb_packet_complete(USBDevice *dev, USBPacket *p)
> int ret;
>
> usb_packet_check_state(p, USB_PACKET_ASYNC);
> - assert(QTAILQ_FIRST(&ep->queue) == p);
> + if (QTAILQ_FIRST(&ep->queue) != p) {
> + trace_usb_assert(usb_bus_from_device(dev)->busnr, dev->port->path, p->ep->nr, p);
> + }
Can you also log QTAILQ_FIRST(&ep->queue) there?
usb_host_* & usb_packet_state_* tracepoints are good to have, usb_uhci_*
is not needed.
>From the trace it looks like the packets are completing in the same
order they have been submitted as they should, I'm puzzled why the
assert triggers ...
Can I also get a "lsusb -v" for the usb device in question?
cheers,
Gerd
next prev parent reply other threads:[~2012-07-02 15:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-22 15:54 [Qemu-devel] usb_packet_complete: Assertion ... failed Jan Kiszka
2012-06-23 9:29 ` Erik Rull
2012-06-23 9:41 ` Jan Kiszka
[not found] ` <4FEB65E5.1060908@rdsoftware.de>
[not found] ` <4FEC5D1B.6040307@siemens.com>
[not found] ` <4FEC7060.2010304@siemens.com>
2012-07-02 11:05 ` Gerd Hoffmann
2012-07-02 14:26 ` Jan Kiszka
2012-07-02 15:47 ` Gerd Hoffmann [this message]
2012-07-02 15:59 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF1C297.4030102@redhat.com \
--to=kraxel@redhat.com \
--cc=erik.rull@rdsoftware.de \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.