From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH] ASoC: tegra: use dmaengine based dma driver Date: Mon, 02 Jul 2012 10:45:01 -0600 Message-ID: <4FF1D00D.6040402@wwwdotorg.org> References: <1340969673-7776-1-git-send-email-ldewangan@nvidia.com> <1340969673-7776-2-git-send-email-ldewangan@nvidia.com> <4FEDDF89.1050907@wwwdotorg.org> <4FEF166D.2010705@nvidia.com> <4FF15B16.9020903@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4FF15B16.9020903-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Laxman Dewangan Cc: "tiwai-l3A5Bk7waGM@public.gmane.org" , "perex-/Fr2/VpizcU@public.gmane.org" , Stephen Warren , "broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org" , "lrg-l0cyMroinI0@public.gmane.org" , "alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-tegra@vger.kernel.org On 07/02/2012 02:25 AM, Laxman Dewangan wrote: > On Saturday 30 June 2012 08:38 PM, Laxman Dewangan wrote: >> On Friday 29 June 2012 10:32 PM, Stephen Warren wrote: >>> On 06/29/2012 05:34 AM, Laxman Dewangan wrote: >>>> Use the dmaengine based Tegra APB DMA driver for >>>> data transfer between SPI fifo and memory in >>>> place of legacy Tegra APB DMA. >>>> >>>> Because generic soc-dmaengine-pcm uses the DMAs API >>>> based on dmaengine, using the exported APIs provided >>>> by this generic driver. >>>> >>>> The new driver is selected if legacy driver is not >>>> selected and new dma driver is enabled through config >>>> file. >>> >>> This works just fine with the existing non-dmaengine DMA driver enabled. >>> >>> However, I can't get it to work with dmaengine: ... >> I think I should send that patches so that you can test it by: >> - Taking already applied dma driver change in linux-next. >> - Apply my new patches which I am going to send. >> >> And do local change in the tegra_defconfig to disable SYSTEM_DMA and >> enable dmaengine based dma driver. > > The new dma patches are: > > dma: tegra: fix residual calculation for cyclic case > dma: tegra: rename driver and compatible to match with dts > ... OK, with those two patches plus this one, everything works on Cardhu/Tegra30 using dmaengine. However, on Tegra20 DMA doesn't appear to work. No audio is heard, and aplay eventually exits with the following error message: aplay: pcm_write:1603: write error: Input/output error I believe this means that the DMA simply isn't operating. I'll assume this is a Tegra20-specific issue in the dmaengine driver itself, and hence not a problem with this patch, so I'll ack this patch. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755866Ab2GBQpI (ORCPT ); Mon, 2 Jul 2012 12:45:08 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:45220 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752519Ab2GBQpG (ORCPT ); Mon, 2 Jul 2012 12:45:06 -0400 Message-ID: <4FF1D00D.6040402@wwwdotorg.org> Date: Mon, 02 Jul 2012 10:45:01 -0600 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Laxman Dewangan CC: "tiwai@suse.de" , "perex@perex.cz" , Stephen Warren , "broonie@opensource.wolfsonmicro.com" , "lrg@ti.com" , "alsa-devel@alsa-project.org" , "linux-kernel@vger.kernel.org" , "linux-tegra@vger.kernel.org" Subject: Re: [PATCH] ASoC: tegra: use dmaengine based dma driver References: <1340969673-7776-1-git-send-email-ldewangan@nvidia.com> <1340969673-7776-2-git-send-email-ldewangan@nvidia.com> <4FEDDF89.1050907@wwwdotorg.org> <4FEF166D.2010705@nvidia.com> <4FF15B16.9020903@nvidia.com> In-Reply-To: <4FF15B16.9020903@nvidia.com> X-Enigmail-Version: 1.5pre Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/02/2012 02:25 AM, Laxman Dewangan wrote: > On Saturday 30 June 2012 08:38 PM, Laxman Dewangan wrote: >> On Friday 29 June 2012 10:32 PM, Stephen Warren wrote: >>> On 06/29/2012 05:34 AM, Laxman Dewangan wrote: >>>> Use the dmaengine based Tegra APB DMA driver for >>>> data transfer between SPI fifo and memory in >>>> place of legacy Tegra APB DMA. >>>> >>>> Because generic soc-dmaengine-pcm uses the DMAs API >>>> based on dmaengine, using the exported APIs provided >>>> by this generic driver. >>>> >>>> The new driver is selected if legacy driver is not >>>> selected and new dma driver is enabled through config >>>> file. >>> >>> This works just fine with the existing non-dmaengine DMA driver enabled. >>> >>> However, I can't get it to work with dmaengine: ... >> I think I should send that patches so that you can test it by: >> - Taking already applied dma driver change in linux-next. >> - Apply my new patches which I am going to send. >> >> And do local change in the tegra_defconfig to disable SYSTEM_DMA and >> enable dmaengine based dma driver. > > The new dma patches are: > > dma: tegra: fix residual calculation for cyclic case > dma: tegra: rename driver and compatible to match with dts > ... OK, with those two patches plus this one, everything works on Cardhu/Tegra30 using dmaengine. However, on Tegra20 DMA doesn't appear to work. No audio is heard, and aplay eventually exits with the following error message: aplay: pcm_write:1603: write error: Input/output error I believe this means that the DMA simply isn't operating. I'll assume this is a Tegra20-specific issue in the dmaengine driver itself, and hence not a problem with this patch, so I'll ack this patch.