From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH] ASoC: tegra: use dmaengine based dma driver Date: Mon, 02 Jul 2012 10:46:59 -0600 Message-ID: <4FF1D083.7060207@wwwdotorg.org> References: <1340969673-7776-1-git-send-email-ldewangan@nvidia.com> <1340969673-7776-2-git-send-email-ldewangan@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1340969673-7776-2-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Laxman Dewangan , broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org Cc: tiwai-l3A5Bk7waGM@public.gmane.org, perex-/Fr2/VpizcU@public.gmane.org, swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, lrg-l0cyMroinI0@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 06/29/2012 05:34 AM, Laxman Dewangan wrote: > Use the dmaengine based Tegra APB DMA driver for > data transfer between SPI fifo and memory in > place of legacy Tegra APB DMA. > > Because generic soc-dmaengine-pcm uses the DMAs API > based on dmaengine, using the exported APIs provided > by this generic driver. > > The new driver is selected if legacy driver is not > selected and new dma driver is enabled through config > file. > > Signed-off-by: Laxman Dewangan Acked-by: Stephen Warren Tested-by: Stephen Warren (Tested on Cardhu/Tegra30. It fails on Whistler/Tegra20, but I assume that's due to a bug in the dmaengine driver not this patch. There won't be a regression when applying this patch since we haven't switched to dmaengine as the default yet). From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755959Ab2GBQrF (ORCPT ); Mon, 2 Jul 2012 12:47:05 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:52141 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752519Ab2GBQrD (ORCPT ); Mon, 2 Jul 2012 12:47:03 -0400 Message-ID: <4FF1D083.7060207@wwwdotorg.org> Date: Mon, 02 Jul 2012 10:46:59 -0600 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Laxman Dewangan , broonie@opensource.wolfsonmicro.com CC: tiwai@suse.de, perex@perex.cz, swarren@nvidia.com, lrg@ti.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH] ASoC: tegra: use dmaengine based dma driver References: <1340969673-7776-1-git-send-email-ldewangan@nvidia.com> <1340969673-7776-2-git-send-email-ldewangan@nvidia.com> In-Reply-To: <1340969673-7776-2-git-send-email-ldewangan@nvidia.com> X-Enigmail-Version: 1.5pre Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/29/2012 05:34 AM, Laxman Dewangan wrote: > Use the dmaengine based Tegra APB DMA driver for > data transfer between SPI fifo and memory in > place of legacy Tegra APB DMA. > > Because generic soc-dmaengine-pcm uses the DMAs API > based on dmaengine, using the exported APIs provided > by this generic driver. > > The new driver is selected if legacy driver is not > selected and new dma driver is enabled through config > file. > > Signed-off-by: Laxman Dewangan Acked-by: Stephen Warren Tested-by: Stephen Warren (Tested on Cardhu/Tegra30. It fails on Whistler/Tegra20, but I assume that's due to a bug in the dmaengine driver not this patch. There won't be a regression when applying this patch since we haven't switched to dmaengine as the default yet).