From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-media@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>,
halli manjunatha <hallimanju@gmail.com>,
Hans Verkuil <hans.verkuil@cisco.com>
Subject: Re: [RFC PATCH 1/6] videodev2.h: add VIDIOC_ENUM_FREQ_BANDS.
Date: Mon, 02 Jul 2012 14:42:33 -0300 [thread overview]
Message-ID: <4FF1DD89.1070209@redhat.com> (raw)
In-Reply-To: <f8baa47c370e4d79309e126b56127df8a5edd11a.1341237775.git.hans.verkuil@cisco.com>
Em 02-07-2012 11:15, Hans Verkuil escreveu:
> From: Hans Verkuil <hans.verkuil@cisco.com>
>
> Add a new ioctl to enumerate the supported frequency bands of a tuner.
>
> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
> ---
> include/linux/videodev2.h | 36 ++++++++++++++++++++++++++----------
> 1 file changed, 26 insertions(+), 10 deletions(-)
>
> diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h
> index f79d0cc..d54ec6e 100644
> --- a/include/linux/videodev2.h
> +++ b/include/linux/videodev2.h
> @@ -2048,6 +2048,7 @@ struct v4l2_modulator {
> #define V4L2_TUNER_CAP_RDS 0x0080
> #define V4L2_TUNER_CAP_RDS_BLOCK_IO 0x0100
> #define V4L2_TUNER_CAP_RDS_CONTROLS 0x0200
> +#define V4L2_TUNER_CAP_FREQ_BANDS 0x0400
>
> /* Flags for the 'rxsubchans' field */
> #define V4L2_TUNER_SUB_MONO 0x0001
> @@ -2066,19 +2067,30 @@ struct v4l2_modulator {
> #define V4L2_TUNER_MODE_LANG1_LANG2 0x0004
>
> struct v4l2_frequency {
> - __u32 tuner;
> - __u32 type; /* enum v4l2_tuner_type */
> - __u32 frequency;
> - __u32 reserved[8];
> + __u32 tuner;
> + __u32 type; /* enum v4l2_tuner_type */
> + __u32 frequency;
> + __u32 reserved[8];
> +};
> +
> +struct v4l2_frequency_band {
> + __u32 tuner;
> + __u32 type; /* enum v4l2_tuner_type */
> + __u32 index;
> + __u32 capability;
> + __u32 rangelow;
> + __u32 rangehigh;
> + __u8 name[32];
As we've discussed, band name can be inferred from the frequency.
Also, there are more than one name for the same band (it could be
named based on the wavelength or frequency - also, some bands or
band segments may have special names, like Tropical Wave).
Let's userspace just call it whatever it wants. So, I'll just
drop it.
On the other hand, the modulation is independent on the band, and
ITU-R and regulator agencies may allow more than one modulation type
and usage for the same frequency (like primary and secondary usage).
So, it makes sense to have an enum here to describe the modulation type
(currenly, AM, FM and VSB).
> + __u32 reserved[6];
> };
>
> struct v4l2_hw_freq_seek {
> - __u32 tuner;
> - __u32 type; /* enum v4l2_tuner_type */
> - __u32 seek_upward;
> - __u32 wrap_around;
> - __u32 spacing;
> - __u32 reserved[7];
> + __u32 tuner;
> + __u32 type; /* enum v4l2_tuner_type */
> + __u32 seek_upward;
> + __u32 wrap_around;
> + __u32 spacing;
> + __u32 reserved[7];
> };
>
> /*
> @@ -2646,6 +2658,10 @@ struct v4l2_create_buffers {
> #define VIDIOC_QUERY_DV_TIMINGS _IOR('V', 99, struct v4l2_dv_timings)
> #define VIDIOC_DV_TIMINGS_CAP _IOWR('V', 100, struct v4l2_dv_timings_cap)
>
> +/* Experimental, this ioctl may change over the next couple of kernel
> + versions. */
> +#define VIDIOC_ENUM_FREQ_BANDS _IOWR('V', 101, struct v4l2_frequency_band)
> +
> /* Reminder: when adding new ioctls please add support for them to
> drivers/media/video/v4l2-compat-ioctl32.c as well! */
>
>
next prev parent reply other threads:[~2012-07-02 17:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-02 14:15 [RFC PATCH 0/6] Add frequency band information Hans Verkuil
2012-07-02 14:15 ` [RFC PATCH 1/6] videodev2.h: add VIDIOC_ENUM_FREQ_BANDS Hans Verkuil
2012-07-02 14:15 ` [RFC PATCH 2/6] v4l2: add core support for the new VIDIOC_ENUM_FREQ_BANDS ioctl Hans Verkuil
2012-07-02 14:15 ` [RFC PATCH 3/6] v4l2 spec: add VIDIOC_ENUM_FREQ_BANDS documentation Hans Verkuil
2012-07-02 14:15 ` [RFC PATCH 4/6] radio-cadet: upgrade to latest frameworks Hans Verkuil
2012-07-02 14:15 ` [RFC PATCH 5/6] radio-cadet: fix RDS handling Hans Verkuil
2012-07-02 14:15 ` [RFC PATCH 6/6] radio-cadet: implement frequency band enumeration Hans Verkuil
2012-07-02 17:42 ` Mauro Carvalho Chehab [this message]
2012-07-03 7:19 ` [RFC PATCH 1/6] videodev2.h: add VIDIOC_ENUM_FREQ_BANDS Hans Verkuil
2012-07-03 16:01 ` Mauro Carvalho Chehab
2012-07-03 16:47 ` Hans Verkuil
2012-07-03 20:35 ` Mauro Carvalho Chehab
2012-07-04 8:35 ` Hans Verkuil
2012-07-04 9:18 ` Hans de Goede
2012-07-02 14:42 ` [RFC PATCH 0/6] Add frequency band information Hans de Goede
2012-07-02 15:24 ` halli manjunatha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF1DD89.1070209@redhat.com \
--to=mchehab@redhat.com \
--cc=hallimanju@gmail.com \
--cc=hans.verkuil@cisco.com \
--cc=hdegoede@redhat.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.